Mailing-List: contact dev-help@phoenix.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@phoenix.apache.org
From: JamesRTaylor <git@git.apache.org>
To: dev@phoenix.apache.org
Reply-To: dev@phoenix.apache.org
References: <git-pr-281-phoenix@git.apache.org>
In-Reply-To: <git-pr-281-phoenix@git.apache.org>
Subject: [GitHub] phoenix pull request #281: PHOENIX-4288 Indexes not used when ordering by pr...
Content-Type: text/plain
Message-Id: <20171115015510.B0324E0810@git1-us-west.apache.org>
Date: Wed, 15 Nov 2017 01:55:10 +0000 (UTC)
archived-at: Wed, 15 Nov 2017 01:55:13 -0000

Github user JamesRTaylor commented on a diff in the pull request:

    https://github.com/apache/phoenix/pull/281#discussion_r151014126
  
    --- Diff: phoenix-core/src/main/java/org/apache/phoenix/execute/HashJoinPlan.java ---
    @@ -290,6 +291,25 @@ public FilterableStatement getStatement() {
             return statement;
         }
     
    +    @Override
    +    public Cost getCost() throws SQLException {
    +        Long byteCount = getEstimatedBytesToScan();
    +        if (byteCount == null) {
    +            return Cost.ZERO;
    +        }
    +
    +        Cost cost = new Cost(0, 0, byteCount);
    +        Cost lhsCost = delegate.getCost();
    +        if (keyRangeExpressions != null) {
    +            lhsCost = lhsCost.multiplyBy(0.01);
    --- End diff --
    
    Why the 0.01? More comments would be good.


---