phoenix-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hadoop QA (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (PHOENIX-4415) Ignore CURRENT_SCN property if set in Pig Storer
Date Thu, 30 Nov 2017 06:10:00 GMT

    [ https://issues.apache.org/jira/browse/PHOENIX-4415?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16272213#comment-16272213
] 

Hadoop QA commented on PHOENIX-4415:
------------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12899941/PHOENIX-4415_v2.patch
  against master branch at commit 355ee522c1d4ff07cf9fbb0a9a01e43e3f702730.
  ATTACHMENT ID: 12899941

    {color:green}+1 @author{color}.  The patch does not contain any @author tags.

    {color:red}-1 tests included{color}.  The patch doesn't appear to include any new or modified
tests.
                        Please justify why no new tests are needed for this patch.
                        Also please list what manual steps were performed to verify this patch.

    {color:green}+1 javac{color}.  The applied patch does not increase the total number of
javac compiler warnings.

    {color:red}-1 release audit{color}.  The applied patch generated 2 release audit warnings
(more than the master's current 0 warnings).

    {color:red}-1 lineLengths{color}.  The patch introduces the following lines longer than
100:
    +    public PhoenixRecordWriter(final Configuration configuration, Set<String> propsToIgnore)
throws SQLException {
+        this.conn = ConnectionUtil.getOutputConnectionWithoutTheseProps(configuration, propsToIgnore);
+    public static Connection getOutputConnectionWithoutTheseProps(final Configuration conf,
Set<String> ignoreTheseProps) throws SQLException {
+    public static Connection getOutputConnection(final Configuration conf, Properties props,
Set<String> withoutTheseProps) throws SQLException {
+    public static Properties combineProperties(Properties props, final Configuration conf,
Set<String> withoutTheseProps) {
+                if (copy.getProperty(entry.getKey()) == null && !withoutTheseProps.contains(entry.getKey()))
{
+        conf.set(PhoenixRuntime.CURRENT_SCN_ATTRIB, Long.toString(System.currentTimeMillis()+QueryConstants.MILLIS_IN_DAY));
+    private static final Set<String> PROPS_TO_IGNORE = Sets.<String>newHashSet(PhoenixRuntime.CURRENT_SCN_ATTRIB);
+    private final PhoenixOutputFormat outputFormat = new PhoenixOutputFormat<PhoenixRecordWritable>(PROPS_TO_IGNORE);

    {color:green}+1 core tests{color}.  The patch passed unit tests in .

Test results: https://builds.apache.org/job/PreCommit-PHOENIX-Build/1644//testReport/
Release audit warnings: https://builds.apache.org/job/PreCommit-PHOENIX-Build/1644//artifact/patchprocess/patchReleaseAuditWarnings.txt
Console output: https://builds.apache.org/job/PreCommit-PHOENIX-Build/1644//console

This message is automatically generated.

> Ignore CURRENT_SCN property if set in Pig Storer
> ------------------------------------------------
>
>                 Key: PHOENIX-4415
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-4415
>             Project: Phoenix
>          Issue Type: Bug
>            Reporter: James Taylor
>            Assignee: James Taylor
>         Attachments: PHOENIX-4415.patch, PHOENIX-4415_v2.patch
>
>
> Phoenix does not support back-in-time writes, so to guard against that we'll remove the
CURRENT_SCN property if it's set in the job configuration in PhoenixHBaseStorage.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message