phoenix-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hadoop QA (JIRA)" <>
Subject [jira] [Commented] (PHOENIX-4398) Change QueryCompiler get column expressions process from serial to parallel.
Date Wed, 22 Nov 2017 18:12:00 GMT


Hadoop QA commented on PHOENIX-4398:

{color:red}-1 overall{color}.  Here are the results of testing the latest attachment
  against master branch at commit c216b667a8da568f768c0d26f46fa1a9c0994a04.
  ATTACHMENT ID: 12898882

    {color:green}+1 @author{color}.  The patch does not contain any @author tags.

    {color:red}-1 tests included{color}.  The patch doesn't appear to include any new or modified
                        Please justify why no new tests are needed for this patch.
                        Also please list what manual steps were performed to verify this patch.

    {color:green}+1 javac{color}.  The applied patch does not increase the total number of
javac compiler warnings.

    {color:red}-1 release audit{color}.  The applied patch generated 2 release audit warnings
(more than the master's current 0 warnings).

    {color:red}-1 lineLengths{color}.  The patch introduces the following lines longer than
    +    private static Configuration config = HBaseFactoryProvider.getConfigurationFactory().getConfiguration();
+    private static boolean use_compile_parallel = config.getBoolean(USE_COMPILE_COLUMN_EXPRESSION_PARALLEL,
+                    expressions[i++] = ((ProjectedColumn) column).getSourceColumnRef().newColumnExpression();
+            return new ExpressionOrder(((ProjectedColumn) column).getSourceColumnRef().newColumnExpression(),
+    public static final String USE_COMPILE_COLUMN_EXPRESSION_PARALLEL = "phoenix.use.columnexpression.parallel";
+    public static final String COMPILE_COLUMN_EXPRESSION_PARALLEL_THREAD = "phoenix.columnexpression.parallel.thread";

     {color:red}-1 core tests{color}.  The patch failed these unit tests:

Test results:
Release audit warnings:
Console output:

This message is automatically generated.

> Change QueryCompiler get column expressions process from serial to parallel.
> ----------------------------------------------------------------------------
>                 Key: PHOENIX-4398
>                 URL:
>             Project: Phoenix
>          Issue Type: Improvement
>    Affects Versions: 4.11.0, 4.13.0
>            Reporter: Albert Lee
>             Fix For: 4.11.0, 4.13.0
>         Attachments: PHOENIX-4398.patch
> When QueryCompiler compile a select sql, the process of getting column expressions is
a serial process. The performance is ok when the table is narrow. But when compile a wide
table(e.g. 130 columns in my use case), The time-consuming of this step is very high, over
70ms. So I change TupleProjector(PTable projectedTable) from serial for loop to parallel future.
> Because this is just modify code performance, not add new feture, so there is no unit

This message was sent by Atlassian JIRA

View raw message