phoenix-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hadoop QA (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (PHOENIX-4381) Calculate the estimatedSize of MutationState incrementally
Date Thu, 16 Nov 2017 05:05:00 GMT

    [ https://issues.apache.org/jira/browse/PHOENIX-4381?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16254760#comment-16254760
] 

Hadoop QA commented on PHOENIX-4381:
------------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12897906/PHOENIX-4381.patch
  against master branch at commit 2053905683409225ffdc1c0ae4fc6c759604a80d.
  ATTACHMENT ID: 12897906

    {color:green}+1 @author{color}.  The patch does not contain any @author tags.

    {color:red}-1 tests included{color}.  The patch doesn't appear to include any new or modified
tests.
                        Please justify why no new tests are needed for this patch.
                        Also please list what manual steps were performed to verify this patch.

    {color:green}+1 javac{color}.  The applied patch does not increase the total number of
javac compiler warnings.

    {color:green}+1 release audit{color}.  The applied patch does not increase the total number
of release audit warnings.

    {color:red}-1 lineLengths{color}.  The patch introduces the following lines longer than
100:
    +        // here we increment the estimated size by the fraction of new rows we added
from the newMutationState 
+            this.estimatedSize += ((double)(this.numRows-oldNumRows)/newMutationState.numRows)
* newMutationState.estimatedSize;
+                            if (logger.isDebugEnabled()) logger.debug("Sent batch of " +
mutationBatch.size() + " for " + Bytes.toString(htableName));
+            getEstimatedRowSize(TableRef tableRef, Map<ImmutableBytesPtr, RowMutationState>
mutations) {

     {color:red}-1 core tests{color}.  The patch failed these unit tests:
     ./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.AbsFunctionEnd2EndIT
./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.ColumnEncodedImmutableNonTxStatsCollectorIT

Test results: https://builds.apache.org/job/PreCommit-PHOENIX-Build/1628//testReport/
Console output: https://builds.apache.org/job/PreCommit-PHOENIX-Build/1628//console

This message is automatically generated.

> Calculate the estimatedSize of MutationState incrementally
> ----------------------------------------------------------
>
>                 Key: PHOENIX-4381
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-4381
>             Project: Phoenix
>          Issue Type: Bug
>    Affects Versions: 4.11.0
>            Reporter: Thomas D'Silva
>            Assignee: Thomas D'Silva
>             Fix For: 4.13.1
>
>         Attachments: PHOENIX-4381.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message