phoenix-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hadoop QA (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (PHOENIX-4373) Local index variable length key can have trailing nulls while upserting
Date Tue, 14 Nov 2017 03:35:00 GMT

    [ https://issues.apache.org/jira/browse/PHOENIX-4373?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16250773#comment-16250773
] 

Hadoop QA commented on PHOENIX-4373:
------------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12897415/PHOENIX-4373.v1.master.patch
  against master branch at commit 1d8a6bc3a6a277d9e3201066b753fa9fd7018545.
  ATTACHMENT ID: 12897415

    {color:green}+1 @author{color}.  The patch does not contain any @author tags.

    {color:red}-1 tests included{color}.  The patch doesn't appear to include any new or modified
tests.
                        Please justify why no new tests are needed for this patch.
                        Also please list what manual steps were performed to verify this patch.

    {color:green}+1 javac{color}.  The applied patch does not increase the total number of
javac compiler warnings.

    {color:green}+1 release audit{color}.  The applied patch does not increase the total number
of release audit warnings.

    {color:red}-1 lineLengths{color}.  The patch introduces the following lines longer than
100:
    +                            + "(ID,CAR_NUM,CAP_DATE,ORG_ID,ORG_NAME) VALUES('1','car1','2016-01-01
00:00:00',11,'orgname1')";
+                                + " WHERE CAR_NUM='car1' AND CAP_DATE>='2016-01-01' AND
CAP_DATE<='2016-05-02' LIMIT 10");

     {color:red}-1 core tests{color}.  The patch failed these unit tests:
     ./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.KeyOnlyIT

Test results: https://builds.apache.org/job/PreCommit-PHOENIX-Build/1625//testReport/
Console output: https://builds.apache.org/job/PreCommit-PHOENIX-Build/1625//console

This message is automatically generated.

> Local index variable length key can have trailing nulls while upserting
> -----------------------------------------------------------------------
>
>                 Key: PHOENIX-4373
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-4373
>             Project: Phoenix
>          Issue Type: Bug
>    Affects Versions: 4.14.0
>            Reporter: Vincent Poon
>            Assignee: Vincent Poon
>         Attachments: PHOENIX-4373.v1.master.patch
>
>
> In the UpsertCompiler#setValues() , if it's a local index, the key is prefixed with regionPrefix.
 During that process, ptr.get() is called to get the base key, and the code assumes the entire
array should be used.  However, if it's a variable length key, we could have trailing nulls
since the base key ptr array size is just an estimate. 



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message