phoenix-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ankit Singhal (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (PHOENIX-4368) Fix MapReduce related classes
Date Thu, 16 Nov 2017 10:24:00 GMT

    [ https://issues.apache.org/jira/browse/PHOENIX-4368?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16255071#comment-16255071
] 

Ankit Singhal commented on PHOENIX-4368:
----------------------------------------

bq. This looks like something that should be lifted to HFile.Writer (with the Java8 default
method fanciness) or moved to a utility class. As it stands, this is marked as private and
we shouldn't be using it in Phoenix. Fine for now, but this is something we should follow
up on HBase. Please create a JIRA for HBase or let me know and I can create one 
Raised HBASE-19280 for moving HFileWriterImpl.compressionByName(defaultCompressionStr) to
some utility class.
But we may need to see if we can refactor the MultiHfileOutputFormat code to remove dependencies
from all private interfaces.(may be difficult to do now but raised PHOENIX-4385 for future
work.)
{code}
import org.apache.hadoop.hbase.io.hfile.HFileContext;
import org.apache.hadoop.hbase.io.hfile.HFileContextBuilder;
import org.apache.hadoop.hbase.regionserver.HStore;
import org.apache.hadoop.hbase.regionserver.StoreFileWriter;
{code}

bq. +1 otherwise
Committed to 5.x branch.


> Fix MapReduce related classes
> -----------------------------
>
>                 Key: PHOENIX-4368
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-4368
>             Project: Phoenix
>          Issue Type: Sub-task
>            Reporter: Josh Elser
>            Assignee: Ankit Singhal
>             Fix For: 5.0.0
>
>         Attachments: PHOENIX-4368.patch
>
>
> A list of what I'm seeing failing right now:
> * PhoenixIndexPartialBuildMapper.java
> * MultiHfileOutputFormat.java
> * FormatToKeyValueReducer.java
> * PhoenixMRJobCallable.java
> * PhoenixInputFormat.java
> * IndexTool.java



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message