phoenix-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Chinmay Kulkarni (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (PHOENIX-4361) Remove redundant argument in separateAndValidateProperties in CQSI
Date Thu, 16 Nov 2017 21:53:00 GMT

    [ https://issues.apache.org/jira/browse/PHOENIX-4361?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16256017#comment-16256017
] 

Chinmay Kulkarni commented on PHOENIX-4361:
-------------------------------------------

[~aertoria] thanks for the review. I moved some of the arguments to the line below for easier
readability since it's difficult to follow a line of code that's 250 characters long in an
IDE. I can still undo this if you want.

> Remove redundant argument in separateAndValidateProperties in CQSI
> ------------------------------------------------------------------
>
>                 Key: PHOENIX-4361
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-4361
>             Project: Phoenix
>          Issue Type: Bug
>            Reporter: Ethan Wang
>            Assignee: Chinmay Kulkarni
>            Priority: Minor
>
> Remove redundant argument in separateAndValidateProperties in CQSI
> private Pair<HTableDescriptor,HTableDescriptor> separateAndValidateProperties(PTable
table, Map<String, List<Pair<String, Object>>> properties, Set<String>
colFamiliesForPColumnsToBeAdded, List<Pair<byte[], Map<String, Object>>>
families, Map<String, Object> tableProps) 
> Map<String, Object>>> families was never used.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message