phoenix-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (PHOENIX-4361) Remove redundant argument in separateAndValidateProperties in CQSI
Date Thu, 16 Nov 2017 21:26:00 GMT

    [ https://issues.apache.org/jira/browse/PHOENIX-4361?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16255990#comment-16255990
] 

ASF GitHub Bot commented on PHOENIX-4361:
-----------------------------------------

Github user aertoria commented on a diff in the pull request:

    https://github.com/apache/phoenix/pull/282#discussion_r151541162
  
    --- Diff: phoenix-core/src/main/java/org/apache/phoenix/query/ConnectionQueryServicesImpl.java
---
    @@ -1940,7 +1940,8 @@ private void setTransactional(HTableDescriptor tableDescriptor,
PTableType table
             this.addCoprocessors(tableDescriptor.getName(), tableDescriptor, tableType, tableProps);
         }
     
    -    private Pair<HTableDescriptor,HTableDescriptor> separateAndValidateProperties(PTable
table, Map<String, List<Pair<String, Object>>> properties, Set<String>
colFamiliesForPColumnsToBeAdded, List<Pair<byte[], Map<String, Object>>>
families, Map<String, Object> tableProps) throws SQLException {
    +    private Pair<HTableDescriptor,HTableDescriptor> separateAndValidateProperties(PTable
table, Map<String, List<Pair<String, Object>>> properties,
    --- End diff --
    
    nit: Please undo this change


> Remove redundant argument in separateAndValidateProperties in CQSI
> ------------------------------------------------------------------
>
>                 Key: PHOENIX-4361
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-4361
>             Project: Phoenix
>          Issue Type: Bug
>            Reporter: Ethan Wang
>            Assignee: Chinmay Kulkarni
>            Priority: Minor
>
> Remove redundant argument in separateAndValidateProperties in CQSI
> private Pair<HTableDescriptor,HTableDescriptor> separateAndValidateProperties(PTable
table, Map<String, List<Pair<String, Object>>> properties, Set<String>
colFamiliesForPColumnsToBeAdded, List<Pair<byte[], Map<String, Object>>>
families, Map<String, Object> tableProps) 
> Map<String, Object>>> families was never used.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message