phoenix-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Samarth Jain (JIRA)" <>
Subject [jira] [Commented] (PHOENIX-4360) Prevent System.Catalog from splitting
Date Sat, 18 Nov 2017 21:59:01 GMT


Samarth Jain commented on PHOENIX-4360:

bq. We can have test, but it we'd just test that HBase doesn't split when told not to split.
(and we have tests for that in HBase).

Still worth a test, IMHO. The test should exercise the code path you added. How else can we
guarantee users that SYSTEM.CATALOG won't split unless we have a test that proves the same

> Prevent System.Catalog from splitting
> -------------------------------------
>                 Key: PHOENIX-4360
>                 URL:
>             Project: Phoenix
>          Issue Type: Bug
>    Affects Versions: 4.13.0
>            Reporter: Lars Hofhansl
>            Assignee: Lars Hofhansl
>            Priority: Blocker
>             Fix For: 4.14.0
>         Attachments: 4360.txt
> Just talked to [~jamestaylor].
> It turns out that currently System.Catalog is not prevented from splitting generally,
but does not allow splitting within a schema.
> In the multi-tenant case that is not good enough. When System.Catalog splits and a base
table and view end up in different regions the following can happen:
> * DROP CASCADE no longer works for those views
> * Adding/removing columns to/from the base table no longer works
> Until PHOENIX-3534 is done we should simply prevent System.Catalog from splitting. (just
like HBase:meta)
> [~apurtell]

This message was sent by Atlassian JIRA

View raw message