phoenix-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Rajeshbabu Chintaguntla (JIRA)" <>
Subject [jira] [Commented] (PHOENIX-4350) Replace deprecated or changed Region methods with new APIs
Date Tue, 07 Nov 2017 08:06:00 GMT


Rajeshbabu Chintaguntla commented on PHOENIX-4350:

Thanks [~anoop.hbase] for review.
bq. So this patch is against Alpha-4?
Yes it's for Alpha-4 only.

bq. In UngroupedAggregateRegionObserver there is a code with Thread.sleep (). This is ugly..
U can make use of the Region#waitForFlushes(long timeout) call here. Seems the code needs
a max wait time also. So this timeout param was added. Will do as part of this issue or some
other issue? Just pointing out. Tks.
The Thread.sleep() not for waiting for flushes but will look at the all places where we can
use the APIs in another JIRA and work out. 

> Replace deprecated or changed Region methods with new APIs
> ----------------------------------------------------------
>                 Key: PHOENIX-4350
>                 URL:
>             Project: Phoenix
>          Issue Type: Sub-task
>            Reporter: Rajeshbabu Chintaguntla
>            Assignee: Rajeshbabu Chintaguntla
>              Labels: HBase-2.0
>             Fix For: 4.14.0
>         Attachments: PHOENIX-4350.patch

This message was sent by Atlassian JIRA

View raw message