phoenix-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hadoop QA (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (PHOENIX-4348) Point deletes do not work when there are immutable indexes with only row key columns
Date Fri, 03 Nov 2017 03:12:00 GMT

    [ https://issues.apache.org/jira/browse/PHOENIX-4348?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16237027#comment-16237027
] 

Hadoop QA commented on PHOENIX-4348:
------------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12895545/PHOENIX-4348.patch
  against master branch at commit 895d067974639cd2205b14940e4e46864b4e2060.
  ATTACHMENT ID: 12895545

    {color:green}+1 @author{color}.  The patch does not contain any @author tags.

    {color:red}-1 tests included{color}.  The patch doesn't appear to include any new or modified
tests.
                        Please justify why no new tests are needed for this patch.
                        Also please list what manual steps were performed to verify this patch.

    {color:green}+1 javac{color}.  The applied patch does not increase the total number of
javac compiler warnings.

    {color:green}+1 release audit{color}.  The applied patch does not increase the total number
of release audit warnings.

    {color:red}-1 lineLengths{color}.  The patch introduces the following lines longer than
100:
    +    public void testPointDeleteRowFromTableWithImmutableIndex(boolean localIndex, boolean
addNonPKIndex) throws Exception {
+                    "CONSTRAINT PK PRIMARY KEY (HOST, DOMAIN, FEATURE, \"DATE\")) IMMUTABLE_ROWS=true");
+            stm.execute("CREATE " + (localIndex ? "LOCAL" : "") + " INDEX " + indexName1
+ " ON " + tableName + " (\"DATE\", FEATURE)");
+            stm.execute("CREATE " + (localIndex ? "LOCAL" : "") + " INDEX " + indexName2
+ " ON " + tableName + " (FEATURE, DOMAIN)");
+                stm.execute("CREATE " + (localIndex ? "LOCAL" : "") + " INDEX " + indexName3
+ " ON " + tableName + " (\"DATE\", FEATURE, USAGE.DB)");
+                    .prepareStatement("UPSERT INTO " + tableName + "(HOST, DOMAIN, FEATURE,
\"DATE\", CORE, DB, ACTIVE_VISITOR) VALUES(?,?, ? , ?, ?, ?, ?)");
+            String dml = "DELETE FROM " + tableName + " WHERE (HOST, DOMAIN, FEATURE, \"DATE\")
= (?,?,?,?)";
+                        return new MutationState(plan.getTableRef(), mutation, 0, maxSize,
maxSizeBytes, connection);

     {color:red}-1 core tests{color}.  The patch failed these unit tests:
     ./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.ConcurrentMutationsIT

Test results: https://builds.apache.org/job/PreCommit-PHOENIX-Build/1613//testReport/
Console output: https://builds.apache.org/job/PreCommit-PHOENIX-Build/1613//console

This message is automatically generated.

> Point deletes do not work when there are immutable indexes with only row key columns
> ------------------------------------------------------------------------------------
>
>                 Key: PHOENIX-4348
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-4348
>             Project: Phoenix
>          Issue Type: Bug
>            Reporter: James Taylor
>            Assignee: James Taylor
>            Priority: Major
>             Fix For: 4.13.0
>
>         Attachments: PHOENIX-4348.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message