phoenix-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hadoop QA (JIRA)" <>
Subject [jira] [Commented] (PHOENIX-4342) Surface QueryPlan in MutationPlan
Date Fri, 03 Nov 2017 02:40:00 GMT


Hadoop QA commented on PHOENIX-4342:

{color:red}-1 overall{color}.  Here are the results of testing the latest attachment
  against master branch at commit 895d067974639cd2205b14940e4e46864b4e2060.
  ATTACHMENT ID: 12895538

    {color:green}+1 @author{color}.  The patch does not contain any @author tags.

    {color:red}-1 tests included{color}.  The patch doesn't appear to include any new or modified
                        Please justify why no new tests are needed for this patch.
                        Also please list what manual steps were performed to verify this patch.

    {color:green}+1 javac{color}.  The applied patch does not increase the total number of
javac compiler warnings.

    {color:green}+1 release audit{color}.  The applied patch does not increase the total number
of release audit warnings.

    {color:red}-1 lineLengths{color}.  The patch introduces the following lines longer than
    +                mutationPlans.add(new SingleRowDeleteMutationPlan(dataPlan, connection,
maxSize, maxSizeBytes));
+            return new ServerSelectDeleteMutationPlan(dataPlan, connection, aggPlan, projector,
maxSize, maxSizeBytes);
+            return new ClientSelectDeleteMutationPlan(targetTableRef, dataPlan, bestPlan,
+                    parallelIteratorFactory, otherTableRefs, projectedTableRef, maxSize,
maxSizeBytes, connection);
+        public SingleRowDeleteMutationPlan(QueryPlan dataPlan, PhoenixConnection connection,
int maxSize, int maxSizeBytes) {
+            Map<ImmutableBytesPtr,RowMutationState> mutation = Maps.newHashMapWithExpectedSize(ranges.getPointLookupCount());
+                mutation.put(new ImmutableBytesPtr(, new
RowMutationState(PRow.DELETE_MARKER, statement.getConnection().getStatementExecutionCounter(),
+            return new MutationState(context.getCurrentTable(), mutation, 0, maxSize, maxSizeBytes,
+        public ServerSelectDeleteMutationPlan(QueryPlan dataPlan, PhoenixConnection connection,
QueryPlan aggPlan,
+                                              RowProjector projector, int maxSize, int maxSizeBytes)

     {color:red}-1 core tests{color}.  The patch failed these unit tests:

Test results:
Console output:

This message is automatically generated.

> Surface QueryPlan in MutationPlan
> ---------------------------------
>                 Key: PHOENIX-4342
>                 URL:
>             Project: Phoenix
>          Issue Type: Improvement
>            Reporter: James Taylor
>            Assignee: Geoffrey Jacoby
>            Priority: Minor
>         Attachments: PHOENIX-4342-v2.patch, PHOENIX-4342.patch
> For DELETE statements, it'd be good to be able to get at the QueryPlan through the MutationPlan
so we can get more structured information at compile time.

This message was sent by Atlassian JIRA

View raw message