phoenix-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Rajeshbabu Chintaguntla (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (PHOENIX-4318) Fix IndexHalfStoreFileReader and related classes
Date Thu, 16 Nov 2017 13:31:02 GMT

    [ https://issues.apache.org/jira/browse/PHOENIX-4318?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16255311#comment-16255311
] 

Rajeshbabu Chintaguntla commented on PHOENIX-4318:
--------------------------------------------------

[~ankit.singhal] [~sergey.soldatov] Thanks for reviews.
bq. – it seems hbaseConn is not closed.
Handled in v3 patch.
bq. – Instead of using deprecated HRegionInfo , can we use RegionInfo.toByteArray(region.getRegionInfo())?
It's package private scope so not able to use it right now. Will check as part of PHOENIX-4304.
bq. – We are resetting refcount on every IndexHalfStoreFileReader creation, shouldn't we
managing it at IndexHalfStoreFileReaderGenerator and passing it along for every reader creation?
As of now we cannot get or pass the refcount from the coprocessors. I think it's ok to pass
ref count as 0.

> Fix IndexHalfStoreFileReader and related classes
> ------------------------------------------------
>
>                 Key: PHOENIX-4318
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-4318
>             Project: Phoenix
>          Issue Type: Sub-task
>            Reporter: Ankit Singhal
>            Assignee: Rajeshbabu Chintaguntla
>              Labels: HBase-2.0
>             Fix For: 4.14.0
>
>         Attachments: PHOENIX-4318_v2.patch, PHOENIX-4318_v3.patch, PHOENIX-4318_wip.patch,
PHOENIX-4318_wip3.patch
>
>
> These classes use the internals of HBase.(And most of them are not accessible in HBase
2.0)
> phoenix-core/src/main/java/org/apache/hadoop/hbase/regionserver/LocalIndexStoreFileScanner.java
> phoenix-core/src/main/java/org/apache/hadoop/hbase/regionserver/IndexHalfStoreFileReader.java
> phoenix-core/src/main/java/org/apache/hadoop/hbase/regionserver/IndexHalfStoreFileReaderGenerator.java
> phoenix-core/src/main/java/org/apache/phoenix/coprocessor/DelegateRegionScanner.java
> phoenix-core/src/main/java/org/apache/phoenix/util/IndexUtil.java
> phoenix-core/src/main/java/org/apache/phoenix/coprocessor/DelegateRegionObserver.java



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message