phoenix-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hadoop QA (JIRA)" <>
Subject [jira] [Commented] (PHOENIX-672) Add GRANT and REVOKE commands using HBase AccessController
Date Thu, 30 Nov 2017 00:04:00 GMT


Hadoop QA commented on PHOENIX-672:

{color:red}-1 overall{color}.  Here are the results of testing the latest attachment
  against master branch at commit 355ee522c1d4ff07cf9fbb0a9a01e43e3f702730.
  ATTACHMENT ID: 12899867

    {color:green}+1 @author{color}.  The patch does not contain any @author tags.

    {color:green}+1 tests included{color}.  The patch appears to include 3 new or modified

    {color:green}+1 javac{color}.  The applied patch does not increase the total number of
javac compiler warnings.

    {color:red}-1 release audit{color}.  The applied patch generated 3 release audit warnings
(more than the master's current 0 warnings).

    {color:red}-1 lineLengths{color}.  The patch introduces the following lines longer than
    +            "SYSTEM.\"CATALOG\"", "SYSTEM.\"SEQUENCE\"", "SYSTEM.\"STATS\"", "SYSTEM.\"FUNCTION\""));
+            QueryConstants.SYSTEM_SCHEMA_NAME + "." + "\"" + PhoenixDatabaseMetaData.SYSTEM_SEQUENCE_TABLE+
+    // DON'T USE HADOOP UserGroupInformation class to create testing users since HBase misses
some of its functionality
+        groupUser = User.createUserForTesting(testUtil.getConfiguration(), "groupUser", new
+        unprivilegedUser = User.createUserForTesting(configuration, "unprivilegedUser", new
+        config.set("hbase.regionserver.wal.codec", "org.apache.hadoop.hbase.regionserver.wal.IndexedWALEditCodec");
+    @Parameterized.Parameters(name = "isNamespaceMapped={0}") // name is used by failsafe
as file name in reports
+    void grantPermissions(String toUser, Set<String> tablesToGrant, Permission.Action...
actions) throws Throwable {
+            AccessControlClient.grant(getUtility().getConnection(), TableName.valueOf(table),
toUser, null, null,
+    void grantPermissions(String toUser, String namespace, Permission.Action... actions)
throws Throwable {

     {color:red}-1 core tests{color}.  The patch failed these unit tests:

Test results:
Release audit warnings:
Console output:

This message is automatically generated.

> Add GRANT and REVOKE commands using HBase AccessController
> ----------------------------------------------------------
>                 Key: PHOENIX-672
>                 URL:
>             Project: Phoenix
>          Issue Type: Task
>            Reporter: James Taylor
>            Assignee: Karan Mehta
>              Labels: namespaces, security
>             Fix For: 4.14.0
>         Attachments: PHOENIX-672.001.patch, PHOENIX-672.002.patch, PHOENIX-672.003.patch
> In HBase 0.98, cell-level security will be available. Take a look at [this](
excellent blog post by @apurtell. Once Phoenix works on 0.96, we should add support for security
to our SQL grammar.

This message was sent by Atlassian JIRA

View raw message