phoenix-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From karanmehta93 <...@git.apache.org>
Subject [GitHub] phoenix pull request #283: PHOENIX-672 Add GRANT and REVOKE commands using H...
Date Wed, 22 Nov 2017 21:44:56 GMT
Github user karanmehta93 commented on a diff in the pull request:

    https://github.com/apache/phoenix/pull/283#discussion_r152685262
  
    --- Diff: phoenix-core/src/main/java/org/apache/phoenix/coprocessor/PhoenixAccessController.java
---
    @@ -229,17 +227,12 @@ public void handleRequireAccessOnDependentTable(String request,
String userName,
                         + dependentTable);
                 return;
             }
    -        if (isAutomaticGrantEnabled) {
    --- End diff --
    
    > Oh, I see.. here we are just talking about removing a config, not the automatic grant
flow in the coprocessor. I'm fine with either having these configs with suitable default or
removing the configs completely
    
    Yes the code flow will still remain and the scenario that you have explained is a valid
one. I will remove both the configs from the code path everywhere. 


---

Mime
View raw message