phoenix-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ankitsinghal <...@git.apache.org>
Subject [GitHub] phoenix pull request #283: PHOENIX-672 Add GRANT and REVOKE commands using H...
Date Wed, 22 Nov 2017 19:14:20 GMT
Github user ankitsinghal commented on a diff in the pull request:

    https://github.com/apache/phoenix/pull/283#discussion_r152656117
  
    --- Diff: phoenix-core/src/main/java/org/apache/phoenix/coprocessor/PhoenixAccessController.java
---
    @@ -229,17 +227,12 @@ public void handleRequireAccessOnDependentTable(String request,
String userName,
                         + dependentTable);
                 return;
             }
    -        if (isAutomaticGrantEnabled) {
    --- End diff --
    
    Oh, I see.. here we are just talking about removing a config, not the automatic grant
flow in the coprocessor. I'm fine with either way, having these configs with suitable default
or removing the configs completely.


---

Mime
View raw message