phoenix-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From JamesRTaylor <...@git.apache.org>
Subject [GitHub] phoenix pull request #283: PHOENIX-672 Add GRANT and REVOKE commands using H...
Date Wed, 22 Nov 2017 18:49:42 GMT
Github user JamesRTaylor commented on a diff in the pull request:

    https://github.com/apache/phoenix/pull/283#discussion_r152650744
  
    --- Diff: phoenix-core/src/main/java/org/apache/phoenix/coprocessor/PhoenixAccessController.java
---
    @@ -229,17 +227,12 @@ public void handleRequireAccessOnDependentTable(String request,
String userName,
                         + dependentTable);
                 return;
             }
    -        if (isAutomaticGrantEnabled) {
    --- End diff --
    
    I don't get the idea of the strict mode option. If this is on, then the grants for secondary
indexes would not be done, essentially breaking things. We already have enough config options,
so I'd be in favor of removing this one.


---

Mime
View raw message