phoenix-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ankitsinghal <...@git.apache.org>
Subject [GitHub] phoenix pull request #283: PHOENIX-672 Add GRANT and REVOKE commands using H...
Date Wed, 22 Nov 2017 07:11:41 GMT
Github user ankitsinghal commented on a diff in the pull request:

    https://github.com/apache/phoenix/pull/283#discussion_r152483233
  
    --- Diff: phoenix-core/src/it/java/org/apache/phoenix/end2end/TableDDLPermissionsIT.java
---
    @@ -210,25 +98,20 @@ public Void run() throws Exception {
                         return null;
                     }
                 });
    -            verifyAllowed(createSchema(schemaName), regularUser);
    +            verifyAllowed(createSchema(schemaName), regularUser1);
                 // Unprivileged user cannot drop a schema
    -            verifyDenied(dropSchema(schemaName), unprivilegedUser);
    -            verifyDenied(createSchema(schemaName), unprivilegedUser);
    +            verifyDenied(dropSchema(schemaName), AccessDeniedException.class, unprivilegedUser);
    +            verifyDenied(createSchema(schemaName), AccessDeniedException.class, unprivilegedUser);
     
    -            verifyAllowed(dropSchema(schemaName), regularUser);
    +            verifyAllowed(dropSchema(schemaName), regularUser1);
             } finally {
                 revokeAll();
             }
         }
     
         @Test
    -    public void testAutomaticGrantDisabled() throws Throwable{
    -        testIndexAndView(false);
    -    }
    --- End diff --
    
    Why is this removed?


---

Mime
View raw message