phoenix-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ankitsinghal <...@git.apache.org>
Subject [GitHub] phoenix pull request #283: PHOENIX-672 Add GRANT and REVOKE commands using H...
Date Wed, 22 Nov 2017 07:00:22 GMT
Github user ankitsinghal commented on a diff in the pull request:

    https://github.com/apache/phoenix/pull/283#discussion_r152481907
  
    --- Diff: phoenix-core/src/main/java/org/apache/phoenix/coprocessor/PhoenixAccessController.java
---
    @@ -229,17 +227,12 @@ public void handleRequireAccessOnDependentTable(String request,
String userName,
                         + dependentTable);
                 return;
             }
    -        if (isAutomaticGrantEnabled) {
    --- End diff --
    
    I think , we can keep this option. as it will help admin if he doesn't want to see the
permissions problems on the dependent table and wants to manage the permission by himself
once the table is created(with downtime) and don't want to rely on the automatic grant.


---

Mime
View raw message