phoenix-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From aertoria <...@git.apache.org>
Subject [GitHub] phoenix pull request #282: PHOENIX-4361: Remove redundant argument in separa...
Date Thu, 16 Nov 2017 21:25:14 GMT
Github user aertoria commented on a diff in the pull request:

    https://github.com/apache/phoenix/pull/282#discussion_r151541162
  
    --- Diff: phoenix-core/src/main/java/org/apache/phoenix/query/ConnectionQueryServicesImpl.java
---
    @@ -1940,7 +1940,8 @@ private void setTransactional(HTableDescriptor tableDescriptor,
PTableType table
             this.addCoprocessors(tableDescriptor.getName(), tableDescriptor, tableType, tableProps);
         }
     
    -    private Pair<HTableDescriptor,HTableDescriptor> separateAndValidateProperties(PTable
table, Map<String, List<Pair<String, Object>>> properties, Set<String>
colFamiliesForPColumnsToBeAdded, List<Pair<byte[], Map<String, Object>>>
families, Map<String, Object> tableProps) throws SQLException {
    +    private Pair<HTableDescriptor,HTableDescriptor> separateAndValidateProperties(PTable
table, Map<String, List<Pair<String, Object>>> properties,
    --- End diff --
    
    nit: Please undo this change


---

Mime
View raw message