Mailing-List: contact dev-help@phoenix.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@phoenix.apache.org
Date: Sun, 29 Oct 2017 16:07:00 +0000 (UTC)
From: "Hadoop QA (JIRA)" <jira@apache.org>
To: dev@phoenix.apache.org
Message-ID: <JIRA.13109775.1508179665000.92021.1509293220301@Atlassian.JIRA>
In-Reply-To: <JIRA.13109775.1508179665000@Atlassian.JIRA>
References: <JIRA.13109775.1508179665000@Atlassian.JIRA> <JIRA.13109775.1508179665667@jira-lw-us.apache.org>
Subject: [jira] [Commented] (PHOENIX-4290) Full table scan performed for
 DELETE with table having immutable indexes
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
archived-at: Sun, 29 Oct 2017 16:07:05 -0000


    [ https://issues.apache.org/jira/browse/PHOENIX-4290?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16224060#comment-16224060 ] 

Hadoop QA commented on PHOENIX-4290:
------------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12894632/PHOENIX-4290_wip10.patch
  against master branch at commit 82a4dd8f78b38c0da6b019ccdead6879b87c6f26.
  ATTACHMENT ID: 12894632

    {color:green}+1 @author{color}.  The patch does not contain any @author tags.

    {color:green}+1 tests included{color}.  The patch appears to include 3 new or modified tests.

    {color:green}+1 javac{color}.  The applied patch does not increase the total number of javac compiler warnings.

    {color:green}+1 release audit{color}.  The applied patch does not increase the total number of release audit warnings.

    {color:red}-1 lineLengths{color}.  The patch introduces the following lines longer than 100:
    +    private static void assertIndexUsed (Connection conn, String query, String indexName, boolean expectedToBeUsed, boolean local) throws SQLException {
+    private static void assertIndexUsed (Connection conn, String query, List<Object> binds, String indexName, boolean expectedToBeUsed, boolean local) throws SQLException {
+                assertEquals(expectedToBeUsed, explainPlan.contains(indexName + " [1]") || explainPlan.contains(indexName + " [1,"));
+    private void testDeleteAllFromTableWithIndex(boolean autoCommit, boolean isSalted) throws Exception {
+    private void testDeleteAllFromTableWithIndex(boolean autoCommit, boolean isSalted, boolean localIndex) throws Exception {
+            TestUtil.dumpTable(con.unwrap(PhoenixConnection.class).getQueryServices().getTable(Bytes.toBytes(tableName)));
+            TestUtil.dumpTable(con.unwrap(PhoenixConnection.class).getQueryServices().getTable(Bytes.toBytes(tableName)));
+            PreparedStatement psDelete = con.prepareStatement("DELETE FROM " + tableName + " WHERE (HOST, DOMAIN, FEATURE, \"DATE\") = (?,?,?,?)");
+            rs = con.createStatement().executeQuery("SELECT /*+ NO_INDEX */ count(*) FROM " + tableName);
+            conn.createStatement().execute("DELETE from " + fullDataTableName + " WHERE long_col2 = 2");

    {color:green}+1 core tests{color}.  The patch passed unit tests in .

Test results: https://builds.apache.org/job/PreCommit-PHOENIX-Build/1587//testReport/
Console output: https://builds.apache.org/job/PreCommit-PHOENIX-Build/1587//console

This message is automatically generated.

> Full table scan performed for DELETE with table having immutable indexes
> ------------------------------------------------------------------------
>
>                 Key: PHOENIX-4290
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-4290
>             Project: Phoenix
>          Issue Type: Bug
>            Reporter: James Taylor
>            Assignee: James Taylor
>             Fix For: 4.13.0, 4.12.1
>
>         Attachments: PHOENIX-4290_wip1.patch, PHOENIX-4290_wip10.patch, PHOENIX-4290_wip2.patch, PHOENIX-4290_wip3.patch, PHOENIX-4290_wip4.patch, PHOENIX-4290_wip5.patch, PHOENIX-4290_wip6.patch, PHOENIX-4290_wip7.patch, PHOENIX-4290_wip8.patch, PHOENIX-4290_wip9.patch
>
>
> If a DELETE command is issued with a partial match for the leading part of the primary key, instead of using the data table, when the table has immutable indexes, a full scan will occur against the index.


--
This message was sent by Atlassian JIRA
(v6.4.14#64029)