Mailing-List: contact dev-help@phoenix.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@phoenix.apache.org
Date: Thu, 26 Oct 2017 21:35:01 +0000 (UTC)
From: "Hadoop QA (JIRA)" <jira@apache.org>
To: dev@phoenix.apache.org
Message-ID: <JIRA.13060807.1490994869000.73154.1509053701746@Atlassian.JIRA>
In-Reply-To: <JIRA.13060807.1490994869000@Atlassian.JIRA>
References: <JIRA.13060807.1490994869000@Atlassian.JIRA> <JIRA.13060807.1490994869966@jira-lw-us.apache.org>
Subject: [jira] [Commented] (PHOENIX-3757) System mutex table not being
 created in SYSTEM namespace when namespace mapping is enabled
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
archived-at: Thu, 26 Oct 2017 21:35:08 -0000


    [ https://issues.apache.org/jira/browse/PHOENIX-3757?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16221271#comment-16221271 ] 

Hadoop QA commented on PHOENIX-3757:
------------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12894191/PHOENIX-3757.005.patch
  against master branch at commit fe13b257e5dfe29581b1c3265d79596f194954cd.
  ATTACHMENT ID: 12894191

    {color:green}+1 @author{color}.  The patch does not contain any @author tags.

    {color:green}+1 tests included{color}.  The patch appears to include 3 new or modified tests.

    {color:green}+1 javac{color}.  The applied patch does not increase the total number of javac compiler warnings.

    {color:green}+1 release audit{color}.  The applied patch does not increase the total number of release audit warnings.

    {color:red}-1 lineLengths{color}.  The patch introduces the following lines longer than 100:
    +            SCHEMA_NAME + "." + MigrateSystemTablesToSystemNamespaceIT.class.getSimpleName().toUpperCase();
+    public void freshClientsCreateNamespaceMappedSystemTables() throws IOException, InterruptedException {
+    // Clients should be restarted with new properties which are consistent on both client and server
+    public void oldClientsAfterSystemTableMigrationShouldFail() throws IOException, InterruptedException {
+            fail("Client should not be able to connect to cluster with inconsistent SYSTEM table namespace properties");
+                fail("UpgradeInProgressException expected since the user is trying to migrate when SYSMUTEX is locked.");
+    private void changeMutexLock(Properties clientProps, boolean acquire) throws SQLException, IOException {
+        byte[] mutexRowKey = SchemaUtil.getTableKey(null, PhoenixDatabaseMetaData.SYSTEM_CATALOG_SCHEMA,
+                        .acquireUpgradeMutex(MetaDataProtocol.MIN_SYSTEM_TABLE_MIGRATION_TIMESTAMP, mutexRowKey));
+        clientProps.setProperty(QueryServices.IS_NAMESPACE_MAPPING_ENABLED, Boolean.TRUE.toString());

     {color:red}-1 core tests{color}.  The patch failed these unit tests:
     ./phoenix-core/target/failsafe-reports/TEST-org.apache.hadoop.hbase.regionserver.wal.WALReplayWithIndexWritesAndCompressedWALIT
./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.SaltedViewIT
./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.ColumnEncodedImmutableNonTxStatsCollectorIT

Test results: https://builds.apache.org/job/PreCommit-PHOENIX-Build/1574//testReport/
Console output: https://builds.apache.org/job/PreCommit-PHOENIX-Build/1574//console

This message is automatically generated.

> System mutex table not being created in SYSTEM namespace when namespace mapping is enabled
> ------------------------------------------------------------------------------------------
>
>                 Key: PHOENIX-3757
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-3757
>             Project: Phoenix
>          Issue Type: Bug
>            Reporter: Josh Elser
>            Assignee: Karan Mehta
>            Priority: Critical
>              Labels: namespaces
>             Fix For: 4.13.0
>
>         Attachments: PHOENIX-3757.001.patch, PHOENIX-3757.002.patch, PHOENIX-3757.003.patch, PHOENIX-3757.004.patch, PHOENIX-3757.005.patch
>
>
> Noticed this issue while writing a test for PHOENIX-3756:
> The SYSTEM.MUTEX table is always created in the default namespace, even when {{phoenix.schema.isNamespaceMappingEnabled=true}}. At a glance, it looks like the logic for the other system tables isn't applied to the mutex table.


--
This message was sent by Atlassian JIRA
(v6.4.14#64029)