Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 4BB78200D4C for ; Wed, 25 Oct 2017 18:03:50 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 4A0A01609DD; Wed, 25 Oct 2017 16:03:50 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 7C544160BDA for ; Wed, 25 Oct 2017 18:03:49 +0200 (CEST) Received: (qmail 17812 invoked by uid 500); 25 Oct 2017 16:03:48 -0000 Mailing-List: contact dev-help@phoenix.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@phoenix.apache.org Delivered-To: mailing list dev@phoenix.apache.org Received: (qmail 17287 invoked by uid 99); 25 Oct 2017 16:03:48 -0000 Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 25 Oct 2017 16:03:48 +0000 Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33) id BE977DFD73; Wed, 25 Oct 2017 16:03:46 +0000 (UTC) From: joshelser To: dev@phoenix.apache.org Reply-To: dev@phoenix.apache.org References: In-Reply-To: Subject: [GitHub] phoenix pull request #277: PHOENIX-3757 System mutex table not being created... Content-Type: text/plain Message-Id: <20171025160346.BE977DFD73@git1-us-west.apache.org> Date: Wed, 25 Oct 2017 16:03:46 +0000 (UTC) archived-at: Wed, 25 Oct 2017 16:03:50 -0000 Github user joshelser commented on a diff in the pull request: https://github.com/apache/phoenix/pull/277#discussion_r146901856 --- Diff: phoenix-core/src/main/java/org/apache/phoenix/query/ConnectionQueryServicesImpl.java --- @@ -2514,7 +2529,7 @@ private void createSysMutexTable(HBaseAdmin admin) throws IOException, SQLExcept return Lists.newArrayList(admin.listTableNames(QueryConstants.SYSTEM_SCHEMA_NAME + "\\..*")); } - private void createOtherSystemTables(PhoenixConnection metaConnection) throws SQLException { + private void createOtherSystemTables(PhoenixConnection metaConnection, HBaseAdmin hBaseAdmin) throws SQLException { --- End diff -- nit: s/hBaseAdmin/hbaseAdmin/ camel-case typically isn't observed on "hbase" ;) ---