Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 6E5F3200D1E for ; Wed, 18 Oct 2017 18:52:52 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 6CE27160BEA; Wed, 18 Oct 2017 16:52:52 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id A74E81609DE for ; Wed, 18 Oct 2017 18:52:51 +0200 (CEST) Received: (qmail 57647 invoked by uid 500); 18 Oct 2017 16:52:50 -0000 Mailing-List: contact dev-help@phoenix.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@phoenix.apache.org Delivered-To: mailing list dev@phoenix.apache.org Received: (qmail 57636 invoked by uid 99); 18 Oct 2017 16:52:50 -0000 Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 18 Oct 2017 16:52:50 +0000 Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33) id 66DFADFAB2; Wed, 18 Oct 2017 16:52:50 +0000 (UTC) From: JamesRTaylor To: dev@phoenix.apache.org Reply-To: dev@phoenix.apache.org References: In-Reply-To: Subject: [GitHub] phoenix issue #275: PHOENIX-4237: Add function to calculate Java collation k... Content-Type: text/plain Message-Id: <20171018165250.66DFADFAB2@git1-us-west.apache.org> Date: Wed, 18 Oct 2017 16:52:50 +0000 (UTC) archived-at: Wed, 18 Oct 2017 16:52:52 -0000 Github user JamesRTaylor commented on the issue: https://github.com/apache/phoenix/pull/275 Looking very good. Couple minor nits and the testing needs to be rounded out just a bit. ---