Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 57F01200D1B for ; Thu, 12 Oct 2017 23:38:59 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 5667A1609E8; Thu, 12 Oct 2017 21:38:59 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 967711609E4 for ; Thu, 12 Oct 2017 23:38:58 +0200 (CEST) Received: (qmail 65204 invoked by uid 500); 12 Oct 2017 21:38:57 -0000 Mailing-List: contact dev-help@phoenix.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@phoenix.apache.org Delivered-To: mailing list dev@phoenix.apache.org Received: (qmail 65193 invoked by uid 99); 12 Oct 2017 21:38:57 -0000 Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 12 Oct 2017 21:38:57 +0000 Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33) id 24CF5DFA0F; Thu, 12 Oct 2017 21:38:55 +0000 (UTC) From: JamesRTaylor To: dev@phoenix.apache.org Reply-To: dev@phoenix.apache.org References: In-Reply-To: Subject: [GitHub] phoenix issue #275: PHOENIX-4237: Add function to calculate Java collation k... Content-Type: text/plain Message-Id: <20171012213856.24CF5DFA0F@git1-us-west.apache.org> Date: Thu, 12 Oct 2017 21:38:55 +0000 (UTC) archived-at: Thu, 12 Oct 2017 21:38:59 -0000 Github user JamesRTaylor commented on the issue: https://github.com/apache/phoenix/pull/275 Thanks for the patch, @shehzaadn. This looks like a general enough built-in function to include in Phoenix IMHO. See inline for more specific comments. It'd be much better to include the first two commits as external dependencies. If we don't do that, we'll need to quickly follow up with replacing them with external dependencies (and make sure we don't change those files at all). ---