phoenix-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hadoop QA (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (PHOENIX-4280) Delete doesn't work when immutable indexes are in building state
Date Fri, 20 Oct 2017 07:58:01 GMT

    [ https://issues.apache.org/jira/browse/PHOENIX-4280?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16212312#comment-16212312
] 

Hadoop QA commented on PHOENIX-4280:
------------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12893174/PHOENIX-4280_v11.patch
  against master branch at commit e50b357a0f8d9c6e8e2e803881e4cc197559b822.
  ATTACHMENT ID: 12893174

    {color:green}+1 @author{color}.  The patch does not contain any @author tags.

    {color:green}+1 tests included{color}.  The patch appears to include 6 new or modified
tests.

    {color:green}+1 javac{color}.  The applied patch does not increase the total number of
javac compiler warnings.

    {color:green}+1 release audit{color}.  The applied patch does not increase the total number
of release audit warnings.

    {color:red}-1 lineLengths{color}.  The patch introduces the following lines longer than
100:
    +            rs = conn.createStatement().executeQuery("SELECT /*+ NO_INDEX*/ COUNT(*)
FROM " + fullTableName);
+            rs = conn.createStatement().executeQuery("SELECT /*+ NO_INDEX*/ COUNT(*) FROM
" + fullTableName);
+            rs = conn.createStatement().executeQuery("SELECT /*+ NO_INDEX*/ COUNT(*) FROM
" + fullTableName);
+            String dml = "DELETE from " + fullTableName + " WHERE varchar_col1='varchar_a'
AND varchar_pk='varchar1'";
+            TestUtil.dumpTable(conn.unwrap(PhoenixConnection.class).getQueryServices().getTable(Bytes.toBytes(fullTableName)));
+            rs = conn.createStatement().executeQuery("SELECT /*+ NO_INDEX*/ COUNT(*) FROM
" + fullTableName);
+        Iterator<Pair<byte[], List<KeyValue>>> iterator = PhoenixRuntime.getUncommittedDataIterator(conn);
+                assertEquals(SQLExceptionCode.INVALID_FILTER_ON_IMMUTABLE_ROWS.getErrorCode(),
e.getErrorCode());
+                        IndexMaintainer maintainer = indexTableRefs.get(i).getTable().getIndexMaintainer(table,
connection);
+                        indexPtr.set(maintainer.buildRowKey(null, indexPtr, null, null, HConstants.LATEST_TIMESTAMP));

     {color:red}-1 core tests{color}.  The patch failed these unit tests:
     ./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.TransactionalViewIT

Test results: https://builds.apache.org/job/PreCommit-PHOENIX-Build/1562//testReport/
Console output: https://builds.apache.org/job/PreCommit-PHOENIX-Build/1562//console

This message is automatically generated.

> Delete doesn't work when immutable indexes are in building state
> ----------------------------------------------------------------
>
>                 Key: PHOENIX-4280
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-4280
>             Project: Phoenix
>          Issue Type: Bug
>            Reporter: James Taylor
>            Assignee: James Taylor
>             Fix For: 4.12.1
>
>         Attachments: PHOENIX-4280.patch, PHOENIX-4280_v10.patch, PHOENIX-4280_v11.patch,
PHOENIX-4280_v2.patch, PHOENIX-4280_v3.patch, PHOENIX-4280_v4.patch, PHOENIX-4280_v5.patch,
PHOENIX-4280_v6.patch, PHOENIX-4280_v7.patch, PHOENIX-4280_v8.patch, PHOENIX-4280_v9.patch,
PHOENIX-4280_wip.patch
>
>
> We don't generate the Delete mutations correctly in this case as we assume we're scanning
over the index table.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message