phoenix-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hadoop QA (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (PHOENIX-4242) Fix Indexer post-compact hook logging of NPE and TableNotFound
Date Thu, 12 Oct 2017 01:35:00 GMT

    [ https://issues.apache.org/jira/browse/PHOENIX-4242?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16201311#comment-16201311
] 

Hadoop QA commented on PHOENIX-4242:
------------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12891586/PHOENIX-4242.v2.master.patch
  against master branch at commit ff80555537ef103f73258115fc766bbe89c430a0.
  ATTACHMENT ID: 12891586

    {color:green}+1 @author{color}.  The patch does not contain any @author tags.

    {color:red}-1 tests included{color}.  The patch doesn't appear to include any new or modified
tests.
                        Please justify why no new tests are needed for this patch.
                        Also please list what manual steps were performed to verify this patch.

    {color:green}+1 javac{color}.  The applied patch does not increase the total number of
javac compiler warnings.

    {color:green}+1 release audit{color}.  The applied patch does not increase the total number
of release audit warnings.

    {color:red}-1 lineLengths{color}.  The patch introduces the following lines longer than
100:
    +        conn.createStatement().execute("CREATE INDEX " + baseTable + "_GLOBAL_IDX ON
" + dataTableFullName + "(CREATED_BY DESC)");
+    public void postCompact(final ObserverContext<RegionCoprocessorEnvironment> c,
final Store store,
+                    String fullTableName = c.getEnvironment().getRegion().getRegionInfo().getTable().getNameAsString();
+        try (PhoenixConnection conn =  QueryUtil.getConnectionOnServer(compactionConfig).unwrap(PhoenixConnection.class)){
+              // for view index physical tables, find all descendants of the data table,
and we'll filter later
+              // if any index or descendant table index is disabled, we won't have all the
data for a rebuild after compaction
+                          logger.info("Major compaction running while index on table is disabled.
 Clearing index disable timestamp: " + index);
+                          IndexUtil.updateIndexState(conn, index.getName().getString(), PIndexState.DISABLE,
Long.valueOf(0L));
+                          logger.warn("Unable to permanently disable index " + index.getName().getString(),
e);
+                  logger.debug("Ignoring HBase table that is not a Phoenix table: " + fullTableName);

     {color:red}-1 core tests{color}.  The patch failed these unit tests:
     ./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.NthValueFunctionIT
./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.UpgradeIT
./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.RangeScanIT
./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.QueryTimeoutIT
./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.RTrimFunctionIT
./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.QueryDatabaseMetaDataIT
./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.NativeHBaseTypesIT

Test results: https://builds.apache.org/job/PreCommit-PHOENIX-Build/1540//testReport/
Console output: https://builds.apache.org/job/PreCommit-PHOENIX-Build/1540//console

This message is automatically generated.

> Fix Indexer post-compact hook logging of NPE and TableNotFound
> --------------------------------------------------------------
>
>                 Key: PHOENIX-4242
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-4242
>             Project: Phoenix
>          Issue Type: Bug
>    Affects Versions: 4.12.0
>            Reporter: Vincent Poon
>            Assignee: Vincent Poon
>         Attachments: PHOENIX-4242.v2.master.patch, PHOENIX-4747.v1.master.patch
>
>
> The post-compact hook in the Indexer seems to log extraneous log messages indicating
NPE or TableNotFound.  The TableNotFound exceptions seem to indicate actual table names prefixed
with MERGE or RESTORE, and sometimes suffixed with a digit, so perhaps these are views or
something similar.
> Examples:
> 2017-09-28 13:35:03,118 WARN  [ctions-1506410238599] index.Indexer - Unable to permanently
disable indexes being partially rebuild for SYSTEM.SEQUENCE
> java.lang.NullPointerException
> 2017-09-28 10:20:56,406 WARN  [ctions-1506410238415] index.Indexer - Unable to permanently
disable indexes being partially rebuild for MERGE_PLATFORM_ENTITY.PLATFORM_IMMUTABLE_ENTITY_DATA2
> org.apache.phoenix.schema.TableNotFoundException: ERROR 1012 (42M03): Table undefined.
tableName=MERGE_PLATFORM_ENTITY.PLATFORM_IMMUTABLE_ENTITY_DATA2



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message