phoenix-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From joshelser <...@git.apache.org>
Subject [GitHub] phoenix pull request #277: PHOENIX-3757 System mutex table not being created...
Date Wed, 25 Oct 2017 16:03:46 GMT
Github user joshelser commented on a diff in the pull request:

    https://github.com/apache/phoenix/pull/277#discussion_r146901856
  
    --- Diff: phoenix-core/src/main/java/org/apache/phoenix/query/ConnectionQueryServicesImpl.java
---
    @@ -2514,7 +2529,7 @@ private void createSysMutexTable(HBaseAdmin admin) throws IOException,
SQLExcept
             return Lists.newArrayList(admin.listTableNames(QueryConstants.SYSTEM_SCHEMA_NAME
+ "\\..*"));
         }
     
    -    private void createOtherSystemTables(PhoenixConnection metaConnection) throws SQLException
{
    +    private void createOtherSystemTables(PhoenixConnection metaConnection, HBaseAdmin
hBaseAdmin) throws SQLException {
    --- End diff --
    
    nit: s/hBaseAdmin/hbaseAdmin/ camel-case typically isn't observed on "hbase" ;)


---

Mime
View raw message