phoenix-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From twdsilva <...@git.apache.org>
Subject [GitHub] phoenix pull request #277: PHOENIX-3757 System mutex table not being created...
Date Tue, 24 Oct 2017 19:06:14 GMT
Github user twdsilva commented on a diff in the pull request:

    https://github.com/apache/phoenix/pull/277#discussion_r146662118
  
    --- Diff: phoenix-core/src/main/java/org/apache/phoenix/query/ConnectionQueryServicesImpl.java
---
    @@ -2905,14 +2918,18 @@ public void upgradeSystemTables(final String url, final Properties
props) throws
                         }
                     } finally {
                         if (acquiredMutexLock) {
    -                        releaseUpgradeMutex(mutexRowKey);
    +                        try {
    +                            releaseUpgradeMutex(mutexRowKey);
    +                        } catch (IOException e) {
    +                            logger.warn("Release of upgrade mutex failed ", e);
    --- End diff --
    
    Is it ok to continue on if we fail to release the upgrade mutex, or should we just let
the exception be thrown?


---

Mime
View raw message