phoenix-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From snakhoda-sfdc <...@git.apache.org>
Subject [GitHub] phoenix issue #275: PHOENIX-4237: Add function to calculate Java collation k...
Date Tue, 17 Oct 2017 18:46:56 GMT
Github user snakhoda-sfdc commented on the issue:

    https://github.com/apache/phoenix/pull/275
  
    @JamesRTaylor Thanks for your comments. I added two further commits:
    
    199c389: This addresses your comment about the byte array comparison. You were right!
I must have got confused earlier with what was being displayed on sqlline.py not matching
the sort order.  I also added a formatter for PVarBinary because without it you simply get
a Java hash code in sqlline.py which is hard to do anything with.
    
    8cc2b5c: This adds the end-to-end tests you mentioned and also changes the unit test to
use the hex representation of the byte array to make it easier to read.


---

Mime
View raw message