phoenix-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From JamesRTaylor <...@git.apache.org>
Subject [GitHub] phoenix issue #275: PHOENIX-4237: Add function to calculate Java collation k...
Date Thu, 12 Oct 2017 21:38:55 GMT
Github user JamesRTaylor commented on the issue:

    https://github.com/apache/phoenix/pull/275
  
    Thanks for the patch, @shehzaadn. This looks like a general enough built-in function to
include in Phoenix IMHO. See inline for more specific comments. It'd be much better to include
the first two commits as external dependencies. If we don't do that, we'll need to quickly
follow up with replacing them with external dependencies (and make sure we don't change those
files at all).


---

Mime
View raw message