Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 72B70200CE6 for ; Fri, 15 Sep 2017 19:16:06 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 719161609D5; Fri, 15 Sep 2017 17:16:06 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id B54A81609C9 for ; Fri, 15 Sep 2017 19:16:05 +0200 (CEST) Received: (qmail 17641 invoked by uid 500); 15 Sep 2017 17:16:04 -0000 Mailing-List: contact dev-help@phoenix.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@phoenix.apache.org Delivered-To: mailing list dev@phoenix.apache.org Received: (qmail 17619 invoked by uid 99); 15 Sep 2017 17:16:04 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 15 Sep 2017 17:16:04 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id 226A1C015D for ; Fri, 15 Sep 2017 17:16:04 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -100.002 X-Spam-Level: X-Spam-Status: No, score=-100.002 tagged_above=-999 required=6.31 tests=[RP_MATCHES_RCVD=-0.001, SPF_PASS=-0.001, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id UqVNAnCbZgjn for ; Fri, 15 Sep 2017 17:16:03 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id 58B745FC1C for ; Fri, 15 Sep 2017 17:16:03 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 73EB1E0933 for ; Fri, 15 Sep 2017 17:16:02 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id B75CE2538F for ; Fri, 15 Sep 2017 17:16:00 +0000 (UTC) Date: Fri, 15 Sep 2017 17:16:00 +0000 (UTC) From: "James Taylor (JIRA)" To: dev@phoenix.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (PHOENIX-4204) Modify SequenceBulkAllocationIT.java to not use currentSCN MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Fri, 15 Sep 2017 17:16:06 -0000 [ https://issues.apache.org/jira/browse/PHOENIX-4204?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16168211#comment-16168211 ] James Taylor commented on PHOENIX-4204: --------------------------------------- +1 on the patch, [~mujtabachohan] with one minor nit: there's no need for a LIMIT 1 here as that statement will always only return a single row: {code} private static final String SELECT_NEXT_VALUE_SQL = - "SELECT NEXT VALUE FOR %s FROM \"SYSTEM\".\"SEQUENCE\" LIMIT 1"; + "SELECT NEXT VALUE FOR %s LIMIT 1"; private static final String SELECT_CURRENT_VALUE_SQL = - "SELECT CURRENT VALUE FOR %s FROM \"SYSTEM\".\"SEQUENCE\" LIMIT 1"; + "SELECT CURRENT VALUE FOR %s LIMIT 1"; {code} Please commit. > Modify SequenceBulkAllocationIT.java to not use currentSCN > ---------------------------------------------------------- > > Key: PHOENIX-4204 > URL: https://issues.apache.org/jira/browse/PHOENIX-4204 > Project: Phoenix > Issue Type: Test > Reporter: Mujtaba Chohan > Assignee: Mujtaba Chohan > Attachments: PHOENIX-4204.patch, PHOENIX-4204_v2.patch > > -- This message was sent by Atlassian JIRA (v6.4.14#64029)