Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 62B54200CFC for ; Thu, 14 Sep 2017 00:47:04 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 619271609CA; Wed, 13 Sep 2017 22:47:04 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id AB1EE1609CB for ; Thu, 14 Sep 2017 00:47:03 +0200 (CEST) Received: (qmail 85242 invoked by uid 500); 13 Sep 2017 22:47:02 -0000 Mailing-List: contact dev-help@phoenix.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@phoenix.apache.org Delivered-To: mailing list dev@phoenix.apache.org Received: (qmail 85231 invoked by uid 99); 13 Sep 2017 22:47:02 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 13 Sep 2017 22:47:02 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id 42AECD4D41 for ; Wed, 13 Sep 2017 22:47:02 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -99.202 X-Spam-Level: X-Spam-Status: No, score=-99.202 tagged_above=-999 required=6.31 tests=[KAM_ASCII_DIVIDERS=0.8, RP_MATCHES_RCVD=-0.001, SPF_PASS=-0.001, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id wJQj0DPdvLtQ for ; Wed, 13 Sep 2017 22:47:01 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTP id 4EE2A5F5B4 for ; Wed, 13 Sep 2017 22:47:01 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 86EF7E099A for ; Wed, 13 Sep 2017 22:47:00 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 3FE9F25383 for ; Wed, 13 Sep 2017 22:47:00 +0000 (UTC) Date: Wed, 13 Sep 2017 22:47:00 +0000 (UTC) From: "James Taylor (JIRA)" To: dev@phoenix.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Updated] (PHOENIX-4180) Modify tests to generate unique table names and not use CURRENT_SCN MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Wed, 13 Sep 2017 22:47:04 -0000 [ https://issues.apache.org/jira/browse/PHOENIX-4180?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] James Taylor updated PHOENIX-4180: ---------------------------------- Attachment: PHOENIX-4180.patch Thanks for the patch, [~rahulshrivastava]. I had to make a few more changes, but what you had got us most of the way there. FYI, here's the final patch. > Modify tests to generate unique table names and not use CURRENT_SCN > ------------------------------------------------------------------- > > Key: PHOENIX-4180 > URL: https://issues.apache.org/jira/browse/PHOENIX-4180 > Project: Phoenix > Issue Type: Bug > Affects Versions: 4.12.0 > Reporter: Rahul Shrivastava > Assignee: Rahul Shrivastava > Priority: Minor > Attachments: PHOENIX-4180.patch > > > Here is update provided by [~jamestaylor] > - switch from using hard coded table names to generated table names (using the BaseTest.generateUniqueName() function). > - remove the setting of the CURRENT_SCN property name > - verify the tests still passes > Here's an example commit of the conversion of one of them: https://git-wip-us.apache.org/repos/asf?p=phoenix.git;a=commitdiff;h=814276d4b4b08be0681f1c402cfb3cc35f01fa0a;hp=b46cbd375e3d2ee9a11644825c13937572c027cd > Here's the list of tests that need to be converted: > ./phoenix-core/src/it/java/org/apache/phoenix/end2end/ArrayIT.java > ./phoenix-core/src/it/java/org/apache/phoenix/end2end/ClientTimeArithmeticQueryIT.java > ./phoenix-core/src/it/java/org/apache/phoenix/end2end/ColumnProjectionOptimizationIT.java > ./phoenix-core/src/it/java/org/apache/phoenix/end2end/ConcurrentMutationsIT.java > ./phoenix-core/src/it/java/org/apache/phoenix/end2end/CursorWithRowValueConstructorIT.java -- This message was sent by Atlassian JIRA (v6.4.14#64029)