Mailing-List: contact dev-help@phoenix.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@phoenix.apache.org
Date: Thu, 7 Sep 2017 04:50:00 +0000 (UTC)
From: "Lars Hofhansl (JIRA)" <jira@apache.org>
To: dev@phoenix.apache.org
Message-ID: <JIRA.13100034.1504674724000.46271.1504759800376@Atlassian.JIRA>
In-Reply-To: <JIRA.13100034.1504674724000@Atlassian.JIRA>
References: <JIRA.13100034.1504674724000@Atlassian.JIRA> <JIRA.13100034.1504674724215@jira-lw-us.apache.org>
Subject: [jira] [Updated] (PHOENIX-4165) Do not wait no new memory chunk can
 be allocated
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
archived-at: Thu, 07 Sep 2017 04:50:05 -0000


     [ https://issues.apache.org/jira/browse/PHOENIX-4165?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Lars Hofhansl updated PHOENIX-4165:
-----------------------------------
    Attachment: 4165-v3.txt

-v3 includes a test:

100 threads allocate chunk of memory in memory, until each of them fails an allocation. Make sure that all memory is used. Then all threads free their allocated chunks, make sure everything was released - I can't think of anything better to test.

This should be good to go.

> Do not wait no new memory chunk can be allocated
> ------------------------------------------------
>
>                 Key: PHOENIX-4165
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-4165
>             Project: Phoenix
>          Issue Type: Bug
>            Reporter: Lars Hofhansl
>         Attachments: 4165.txt, 4165-v2.txt, 4165-v3.txt
>
>
> Currently the code waits for up to 10s by fault for memory to become "available".
> I think it's better to fail immediately and the let the client retry rather than waiting on an HBase handler thread.
> In a first iteration we can simply set the max wait time to 0 (or perhaps even -1) so that we do not attempt to wait but fail immediately. All using code should already deal with InsufficientMemoryExceptions, since they can already happen right now,
> In a second step I'd suggest to actually remove the waiting code and config option completely.
> [~jamestaylor]


--
This message was sent by Atlassian JIRA
(v6.4.14#64029)