Mailing-List: contact dev-help@phoenix.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@phoenix.apache.org
Date: Tue, 5 Sep 2017 16:42:00 +0000 (UTC)
From: "James Taylor (JIRA)" <jira@apache.org>
To: dev@phoenix.apache.org
Message-ID: <JIRA.13099474.1504462870000.30131.1504629720292@Atlassian.JIRA>
In-Reply-To: <JIRA.13099474.1504462870000@Atlassian.JIRA>
References: <JIRA.13099474.1504462870000@Atlassian.JIRA> <JIRA.13099474.1504462870812@jira-lw-us.apache.org>
Subject: [jira] [Comment Edited] (PHOENIX-4156) Fix flapping
 MutableIndexFailureIT
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
archived-at: Tue, 05 Sep 2017 16:42:10 -0000


    [ https://issues.apache.org/jira/browse/PHOENIX-4156?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16153944#comment-16153944 ] 

James Taylor edited comment on PHOENIX-4156 at 9/5/17 4:41 PM:
---------------------------------------------------------------

bq. I wanted to disable the scheduled thread so the test can execute the rebuild task itself and assert the state of indexes. I don't think we can do that by setting the "do not rebuild" index policy on the table.
I see. That seems fine then. Why not a default for the delay of 0? So in other words, just have a new QueryServicesOptions.DEFAULT_INDEX_REBUILD_TASK_INITIAL_DELAY with a value of 0.
{code}
+        initialRebuildTaskDelay = 
+                config.getLong(
+                    QueryServices.INDEX_REBUILD_TASK_INITIAL_DELAY,
+                    QueryServicesOptions.DEFAULT_INDEX_FAILURE_HANDLING_REBUILD_INTERVAL);
{code}

bq. when the disableIndexOnWriteFailure=false and rebuildIndexOnFailure=false, we are relying on the users to replay the mutations, right? So in this case the index disable timestamp shouldn't be set?
Correct.


was (Author: jamestaylor):
bq. I wanted to disable the scheduled thread so the test can execute the rebuild task itself and assert the state of indexes. I don't think we can do that by setting the "do not rebuild" index policy on the table.
I see. That seems fine then. Why not a default for the delay of 0?

bq. when the disableIndexOnWriteFailure=false and rebuildIndexOnFailure=false, we are relying on the users to replay the mutations, right? So in this case the index disable timestamp shouldn't be set?
Correct.

> Fix flapping MutableIndexFailureIT
> ----------------------------------
>
>                 Key: PHOENIX-4156
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-4156
>             Project: Phoenix
>          Issue Type: Bug
>            Reporter: Samarth Jain
>            Assignee: Samarth Jain
>         Attachments: PHOENIX-4156_v1.patch, PHOENIX-4156_v2.patch, PHOENIX-4156_v3.patch, PHOENIX-4156_v4.patch
>
>


--
This message was sent by Atlassian JIRA
(v6.4.14#64029)