phoenix-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "James Taylor (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (PHOENIX-4238) MR IndexScrutinyTool break with salted tables and indexes on views
Date Fri, 29 Sep 2017 18:47:00 GMT

    [ https://issues.apache.org/jira/browse/PHOENIX-4238?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16186223#comment-16186223
] 

James Taylor commented on PHOENIX-4238:
---------------------------------------

Thanks, [~churromorales]. There's one more index column you have to skip in addition to the
salt column (which is used for indexes on views and local indexes). See my patch over on PHOENIX-4233
or this block of code:
{code}
         PTable pindex = pconn.getTable(new PTableKey(pconn.getTenantId(), fullIndexName));
+        List<PColumn> indexColumns = pindex.getColumns();
+        int indexColumnOffset = 0;
+        if (pindex.getBucketNum() != null) {
+            indexColumnOffset = 1;
+        }
+        if (pindex.getViewIndexId() != null) {
+            indexColumnOffset++;
+        }
+        if (indexColumnOffset > 0) {
+            indexColumns = indexColumns.subList(indexColumnOffset, indexColumns.size());
+        }
{code}

> MR IndexScrutinyTool break with salted tables and indexes on views
> ------------------------------------------------------------------
>
>                 Key: PHOENIX-4238
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-4238
>             Project: Phoenix
>          Issue Type: Bug
>    Affects Versions: 4.12.0
>            Reporter: Vincent Poon
>            Assignee: churro morales
>         Attachments: PHOENIX-4238.patch, PHOENIX-4238.v1.patch
>
>
> The IndexScrutinyTool MR job doesn't work for salted and shared table.  We should add
support for this, similar to PHOENIX-4233



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message