phoenix-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hadoop QA (JIRA)" <>
Subject [jira] [Commented] (PHOENIX-4220) Upper bound not being used in partial index rebuilder
Date Thu, 21 Sep 2017 19:56:01 GMT


Hadoop QA commented on PHOENIX-4220:

{color:red}-1 overall{color}.  Here are the results of testing the latest attachment
  against master branch at commit 3fb104ee56518ca066672e199bff1ed4f4bd9a7e.
  ATTACHMENT ID: 12888330

    {color:green}+1 @author{color}.  The patch does not contain any @author tags.

    {color:red}-1 tests included{color}.  The patch doesn't appear to include any new or modified
                        Please justify why no new tests are needed for this patch.
                        Also please list what manual steps were performed to verify this patch.

    {color:green}+1 javac{color}.  The applied patch does not increase the total number of
javac compiler warnings.

    {color:green}+1 release audit{color}.  The applied patch does not increase the total number
of release audit warnings.

    {color:red}-1 lineLengths{color}.  The patch introduces the following lines longer than
    +        serverProps.put(QueryServices.INDEX_FAILURE_HANDLING_REBUILD_INTERVAL_ATTRIB,
+            conn.createStatement().execute("CREATE TABLE " + fullTableName + "(k VARCHAR
+            conn.createStatement().execute("CREATE INDEX " + indexName + " ON " + fullTableName
+ " (v1, v2)");
+            HTableInterface metaTable = conn.unwrap(PhoenixConnection.class).getQueryServices().getTable(PhoenixDatabaseMetaData.SYSTEM_CATALOG_NAME_BYTES);
+            conn.createStatement().execute("UPSERT INTO " + fullTableName + " VALUES('a','a',
+            // Set clock forward in time past the "overlap" amount we wait for index maintenance
to kick in
+            conn.createStatement().execute("UPSERT INTO " + fullTableName + " VALUES('bb','bb','11')");
+    private static void waitForIndexRebuild(Connection conn, String fullIndexName, PIndexState
expectedIndexState, MyClock clock, long increment) throws InterruptedException, SQLException
+                                    getTimestampForBatch(scanBeginTime,batchExecutedPerTableMap.get(dataPTable.getName())));
+							MutationPlan plan = compiler.compile(Collections.singletonList(tableRef), null, null,
null, scanEndTime);

    {color:green}+1 core tests{color}.  The patch passed unit tests in .

Test results:
Console output:

This message is automatically generated.

> Upper bound not being used in partial index rebuilder
> -----------------------------------------------------
>                 Key: PHOENIX-4220
>                 URL:
>             Project: Phoenix
>          Issue Type: Bug
>            Reporter: James Taylor
>            Assignee: James Taylor
>             Fix For: 4.12.0
>         Attachments: PHOENIX-4220.patch, PHOENIX-4220_v2.patch
> Though we're setting the scan upper and lower bound, it's not taking effect in the index
rebuilder. Thus, we're rebuilding from the lower bound to the latest timestamp which is bad
if the table is taking a lot of writes.

This message was sent by Atlassian JIRA

View raw message