phoenix-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hadoop QA (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (PHOENIX-4217) Revert REPLAY_AT capability
Date Fri, 15 Sep 2017 23:31:01 GMT

    [ https://issues.apache.org/jira/browse/PHOENIX-4217?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16168675#comment-16168675
] 

Hadoop QA commented on PHOENIX-4217:
------------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12887448/PHOENIX-4217.patch
  against master branch at commit c06ef877efa2c55de3430c8289ebad63e8bebc93.
  ATTACHMENT ID: 12887448

    {color:green}+1 @author{color}.  The patch does not contain any @author tags.

    {color:red}-1 tests included{color}.  The patch doesn't appear to include any new or modified
tests.
                        Please justify why no new tests are needed for this patch.
                        Also please list what manual steps were performed to verify this patch.

    {color:green}+1 javac{color}.  The applied patch does not increase the total number of
javac compiler warnings.

    {color:green}+1 release audit{color}.  The applied patch does not increase the total number
of release audit warnings.

    {color:red}-1 lineLengths{color}.  The patch introduces the following lines longer than
100:
    +        this(connection.getQueryServices(), connection.getURL(), connection.getClientInfo(),
connection.metaData, connection.getMutationState(), isDescRowKeyOrderUpgrade, isRunningUpgrade);
+        this(connection.getQueryServices(), connection.getURL(), connection.getClientInfo(),
connection.getMetaDataCache(), mutationState, connection.isDescVarLengthRowKeyUpgrade(), connection.isRunningUpgrade());
+        this(services, connection.getURL(), newPropsWithSCN(scn,connection.getClientInfo()),
connection.metaData, connection.getMutationState(), connection.isDescVarLengthRowKeyUpgrade(),
connection.isRunningUpgrade());
+        this(services, connection.url, info, connection.metaData, null, connection.isDescVarLengthRowKeyUpgrade(),
connection.isRunningUpgrade());
+    private PhoenixConnection(ConnectionQueryServices services, String url, Properties info,
PMetaData metaData, MutationState mutationState, boolean isDescVarLengthRowKeyUpgrade, boolean
isRunningUpgrade) throws SQLException {

     {color:red}-1 core tests{color}.  The patch failed these unit tests:
     

Test results: https://builds.apache.org/job/PreCommit-PHOENIX-Build/1452//testReport/
Console output: https://builds.apache.org/job/PreCommit-PHOENIX-Build/1452//console

This message is automatically generated.

> Revert REPLAY_AT capability
> ---------------------------
>
>                 Key: PHOENIX-4217
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-4217
>             Project: Phoenix
>          Issue Type: Bug
>            Reporter: James Taylor
>            Assignee: James Taylor
>             Fix For: 4.12.0
>
>         Attachments: PHOENIX-4217.patch
>
>
> Mutable secondary indexing cannot maintain consistency if the user supplies the time
stamps, hence the not-yet-released REPLAY_AT functionality cannot be supported.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message