phoenix-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "James Taylor (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (PHOENIX-4204) Modify SequenceBulkAllocationIT.java to not use currentSCN
Date Fri, 15 Sep 2017 17:16:00 GMT

    [ https://issues.apache.org/jira/browse/PHOENIX-4204?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16168211#comment-16168211
] 

James Taylor commented on PHOENIX-4204:
---------------------------------------

+1 on the patch, [~mujtabachohan] with one minor nit: there's no need for a LIMIT 1 here as
that statement will always only return a single row:
{code}
     private static final String SELECT_NEXT_VALUE_SQL =
-            "SELECT NEXT VALUE FOR %s FROM \"SYSTEM\".\"SEQUENCE\" LIMIT 1";
+            "SELECT NEXT VALUE FOR %s LIMIT 1";
     private static final String SELECT_CURRENT_VALUE_SQL =
-            "SELECT CURRENT VALUE FOR %s FROM \"SYSTEM\".\"SEQUENCE\" LIMIT 1";
+            "SELECT CURRENT VALUE FOR %s LIMIT 1";
{code}

Please commit.

> Modify SequenceBulkAllocationIT.java to not use currentSCN
> ----------------------------------------------------------
>
>                 Key: PHOENIX-4204
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-4204
>             Project: Phoenix
>          Issue Type: Test
>            Reporter: Mujtaba Chohan
>            Assignee: Mujtaba Chohan
>         Attachments: PHOENIX-4204.patch, PHOENIX-4204_v2.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message