phoenix-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Josh Elser (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (PHOENIX-4191) Not all ITs being run
Date Tue, 12 Sep 2017 21:32:00 GMT

    [ https://issues.apache.org/jira/browse/PHOENIX-4191?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16163693#comment-16163693
] 

Josh Elser commented on PHOENIX-4191:
-------------------------------------

bq. We're still on JDK 7 here, so I don't think that plugin will help us.

Yes, and no. The plugin just requires a JDK8 installation; we can still have the compiler
source/target set to 7 and use this plugin. The current downside is just when developers haven't
yet installed a JDK8 compiler, the check wouldn't run for those folks which isn't a big deal.
I'd assume the large majority of developers are still using JDK8 to build JDK7 targeted code
(at least I've been doing that for some time). Does that make sense/alleviate concern?

The only rub is that I do have to use a JDK7 installation when building the 0.98 branch. There's
some issue with HBase 0.98 which results in a unit test hanging if you try to use JDK8 (even
with the Java7 target). Even then, not a big concern since catching an IT in master will result
in a change to all branches.

bq. How about just adding an annotation to the test classes where it's missing? Wouldn't that
be a simpler solution, especially for 4.12?

Yup, that's always a path forward, regardless of the above outcome.

> Not all ITs being run
> ---------------------
>
>                 Key: PHOENIX-4191
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-4191
>             Project: Phoenix
>          Issue Type: Bug
>            Reporter: Josh Elser
>            Assignee: Josh Elser
>            Priority: Blocker
>             Fix For: 4.12.0
>
>         Attachments: PHOENIX-4191.001.patch, PHOENIX-4191.002.patch
>
>
> Noticed that not all of the ITs are getting run, specifically SystemTablePermissionsIT.
> It seems like we have the build set up to require that all ITs fall into a specific bucket
of categories. Those not in one of those categories are ignored.
> Marked as blocker as we've had regressions around security in this part of the code before.
Must make sure this test is running before a release happens.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message