phoenix-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "James Taylor (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (PHOENIX-4187) Use server timestamp for ROW_TIMESTAMP column when value is not specified
Date Wed, 27 Sep 2017 16:18:00 GMT

    [ https://issues.apache.org/jira/browse/PHOENIX-4187?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16182824#comment-16182824
] 

James Taylor commented on PHOENIX-4187:
---------------------------------------

+1 on the patch with one minor nit: please change System.currentTimeMillis() to EnvironmentEdgeManager.currentTimeMillis()
(the one in org.apache.phoenix.util). Also, one question: how do we handle when UPDATE_CACHE_FREQUENCY
is used on a table with ROW_TIMESTAMP? If we can force the update cache from MutationState,
that'd be ideal.

Nice work, [~tdsilva]!

> Use server timestamp for ROW_TIMESTAMP column when value is not specified
> -------------------------------------------------------------------------
>
>                 Key: PHOENIX-4187
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-4187
>             Project: Phoenix
>          Issue Type: Bug
>            Reporter: Samarth Jain
>            Assignee: Thomas D'Silva
>             Fix For: 4.12.0
>
>         Attachments: PHOENIX-4187.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message