phoenix-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "James Taylor (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (PHOENIX-4180) Modify tests to generate unique table names and not use CURRENT_SCN
Date Wed, 13 Sep 2017 22:47:00 GMT

     [ https://issues.apache.org/jira/browse/PHOENIX-4180?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

James Taylor updated PHOENIX-4180:
----------------------------------
    Attachment: PHOENIX-4180.patch

Thanks for the patch, [~rahulshrivastava]. I had to make a few more changes, but what you
had got us most of the way there. FYI, here's the final patch.

> Modify tests to generate unique table names and not use CURRENT_SCN
> -------------------------------------------------------------------
>
>                 Key: PHOENIX-4180
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-4180
>             Project: Phoenix
>          Issue Type: Bug
>    Affects Versions: 4.12.0
>            Reporter: Rahul Shrivastava
>            Assignee: Rahul Shrivastava
>            Priority: Minor
>         Attachments: PHOENIX-4180.patch
>
>
> Here is update provided by [~jamestaylor]
> - switch from using hard coded table names to generated table names (using the BaseTest.generateUniqueName()
function).
> - remove the setting of the CURRENT_SCN property name
> - verify the tests still passes
> Here's an example commit of the conversion of one of them: https://git-wip-us.apache.org/repos/asf?p=phoenix.git;a=commitdiff;h=814276d4b4b08be0681f1c402cfb3cc35f01fa0a;hp=b46cbd375e3d2ee9a11644825c13937572c027cd
> Here's the list of tests that need to be converted:
> ./phoenix-core/src/it/java/org/apache/phoenix/end2end/ArrayIT.java
> ./phoenix-core/src/it/java/org/apache/phoenix/end2end/ClientTimeArithmeticQueryIT.java
> ./phoenix-core/src/it/java/org/apache/phoenix/end2end/ColumnProjectionOptimizationIT.java
> ./phoenix-core/src/it/java/org/apache/phoenix/end2end/ConcurrentMutationsIT.java
> ./phoenix-core/src/it/java/org/apache/phoenix/end2end/CursorWithRowValueConstructorIT.java



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message