phoenix-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "James Taylor (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (PHOENIX-4170) Remove rebuildIndexOnFailure param from MutableIndexFailureIT
Date Wed, 06 Sep 2017 19:15:00 GMT

    [ https://issues.apache.org/jira/browse/PHOENIX-4170?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16155901#comment-16155901
] 

James Taylor commented on PHOENIX-4170:
---------------------------------------

Would MutableIndexFailureIT still test the scenario of the rebuilder be off? If so, we may
still need this if statement:
{code}
@@ -340,15 +336,9 @@ public class MutableIndexFailureIT extends BaseTest {
             if (!failRebuildTask) {
                 // re-enable index table
                 FailingRegionObserver.FAIL_WRITE = false;
-                if (rebuildIndexOnWriteFailure) {
-                    runRebuildTask(conn);
-                    // wait for index to be rebuilt automatically
-                    checkStateAfterRebuild(conn, fullIndexName, PIndexState.ACTIVE);
-                } else {
-                    // simulate replaying failed mutation
-                    replayMutations();
-                }
-
+                runRebuildTask(conn);
+                // wait for index to be rebuilt automatically
+                checkStateAfterRebuild(conn, fullIndexName, PIndexState.ACTIVE);
{code}

> Remove rebuildIndexOnFailure param from MutableIndexFailureIT
> -------------------------------------------------------------
>
>                 Key: PHOENIX-4170
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-4170
>             Project: Phoenix
>          Issue Type: Bug
>            Reporter: Samarth Jain
>            Assignee: Samarth Jain
>         Attachments: PHOENIX-4170.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message