phoenix-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hadoop QA (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (PHOENIX-4169) Explicitly cap timeout for index disable RPC on compaction
Date Tue, 12 Sep 2017 05:05:00 GMT

    [ https://issues.apache.org/jira/browse/PHOENIX-4169?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16162504#comment-16162504
] 

Hadoop QA commented on PHOENIX-4169:
------------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12886558/PHOENIX-4169.master.patch
  against master branch at commit 1d4025a57daedeebb64ef735b1055ebc9c6b2131.
  ATTACHMENT ID: 12886558

    {color:green}+1 @author{color}.  The patch does not contain any @author tags.

    {color:red}-1 tests included{color}.  The patch doesn't appear to include any new or modified
tests.
                        Please justify why no new tests are needed for this patch.
                        Also please list what manual steps were performed to verify this patch.

    {color:green}+1 javac{color}.  The applied patch does not increase the total number of
javac compiler warnings.

    {color:green}+1 release audit{color}.  The applied patch does not increase the total number
of release audit warnings.

    {color:red}-1 lineLengths{color}.  The patch introduces the following lines longer than
100:
    +                    Configuration clonedConfig = PropertiesUtil.cloneConfig(e.getEnvironment().getConfiguration());
+                        e.getEnvironment().getConfiguration().getInt(QueryServices.NUM_RETRIES_FOR_SCHEMA_UPDATE_CHECK,

    {color:green}+1 core tests{color}.  The patch passed unit tests in .

     {color:red}-1 core zombie tests{color}.  There are 3 zombie test(s): 	at org.apache.hadoop.hbase.client.TestSnapshotWithAcl.testRestoreSnapshot(TestSnapshotWithAcl.java:190)

Test results: https://builds.apache.org/job/PreCommit-PHOENIX-Build/1426//testReport/
Console output: https://builds.apache.org/job/PreCommit-PHOENIX-Build/1426//console

This message is automatically generated.

> Explicitly cap timeout for index disable RPC on compaction
> ----------------------------------------------------------
>
>                 Key: PHOENIX-4169
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-4169
>             Project: Phoenix
>          Issue Type: Bug
>    Affects Versions: 4.12.0
>            Reporter: Vincent Poon
>            Assignee: Vincent Poon
>            Priority: Critical
>         Attachments: PHOENIX-4169.0.98.patch, PHOENIX-4169.master.patch
>
>
> In PHOENIX-3953 we're marking the mutable global index as disabled with an index_disable_timestamp
of 0 from the compaction hook.This is a potentially a server-server RPC, and HConnectionManager#setServerSideHConnectionRetries
makes it such that the HBase client config on the server side has 10 times the number of retries,
lasting hours.
> To avoid a hung coprocessor hook, we should explicitly cap the number of retries here.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message