phoenix-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hudson (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (PHOENIX-4165) Do not wait no new memory chunk can be allocated
Date Sat, 09 Sep 2017 07:32:00 GMT

    [ https://issues.apache.org/jira/browse/PHOENIX-4165?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16159811#comment-16159811
] 

Hudson commented on PHOENIX-4165:
---------------------------------

SUCCESS: Integrated in Jenkins build Phoenix-master #1784 (See [https://builds.apache.org/job/Phoenix-master/1784/])
PHOENIX-4165 Do not wait no new memory chunk can be allocated. (larsh: rev 44c00345b946cbdd9fc8205f8121cd60a065c0fe)
* (edit) phoenix-core/src/main/java/org/apache/phoenix/query/BaseQueryServicesImpl.java
* (edit) phoenix-core/src/main/java/org/apache/phoenix/cache/GlobalCache.java
* (edit) phoenix-core/src/test/java/org/apache/phoenix/memory/MemoryManagerTest.java
* (edit) phoenix-core/src/main/java/org/apache/phoenix/query/QueryServices.java
* (edit) phoenix-core/src/main/java/org/apache/phoenix/query/QueryServicesOptions.java
* (edit) phoenix-core/src/test/java/org/apache/phoenix/cache/TenantCacheTest.java
* (edit) phoenix-core/src/main/java/org/apache/phoenix/memory/GlobalMemoryManager.java
* (edit) phoenix-core/src/test/java/org/apache/phoenix/query/QueryServicesTestImpl.java
* (edit) phoenix-core/src/test/java/org/apache/phoenix/iterate/SpoolingResultIteratorTest.java


> Do not wait no new memory chunk can be allocated
> ------------------------------------------------
>
>                 Key: PHOENIX-4165
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-4165
>             Project: Phoenix
>          Issue Type: Bug
>    Affects Versions: 4.11.0
>            Reporter: Lars Hofhansl
>            Assignee: Lars Hofhansl
>             Fix For: 4.12.0
>
>         Attachments: 4165-4.x-HBase-0.98.txt, 4165.txt, 4165-v2.txt, 4165-v3.txt, 4165-v4.txt,
4165-v4.txt
>
>
> Currently the code waits for up to 10s by fault for memory to become "available".
> I think it's better to fail immediately and the let the client retry rather than waiting
on an HBase handler thread.
> In a first iteration we can simply set the max wait time to 0 (or perhaps even -1) so
that we do not attempt to wait but fail immediately. All using code should already deal with
InsufficientMemoryExceptions, since they can already happen right now,
> In a second step I'd suggest to actually remove the waiting code and config option completely.
> [~jamestaylor]



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message