phoenix-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Samarth Jain (JIRA)" <>
Subject [jira] [Commented] (PHOENIX-4165) Do not wait no new memory chunk can be allocated
Date Thu, 07 Sep 2017 21:18:00 GMT


Samarth Jain commented on PHOENIX-4165:

[~lhofhansl] - I would also recommend attaching a patch ending with 4.x-HBase-0.98 to trigger
a pre-commit build against the 0.98 branch too. There is a bit of divergence (but not a lot)
between our 0.98 and master branches, so it is always a good idea to run tests for the two.

> Do not wait no new memory chunk can be allocated
> ------------------------------------------------
>                 Key: PHOENIX-4165
>                 URL:
>             Project: Phoenix
>          Issue Type: Bug
>    Affects Versions: 4.11.0
>            Reporter: Lars Hofhansl
>            Assignee: Lars Hofhansl
>             Fix For: 4.12.0
>         Attachments: 4165.txt, 4165-v2.txt, 4165-v3.txt, 4165-v4.txt
> Currently the code waits for up to 10s by fault for memory to become "available".
> I think it's better to fail immediately and the let the client retry rather than waiting
on an HBase handler thread.
> In a first iteration we can simply set the max wait time to 0 (or perhaps even -1) so
that we do not attempt to wait but fail immediately. All using code should already deal with
InsufficientMemoryExceptions, since they can already happen right now,
> In a second step I'd suggest to actually remove the waiting code and config option completely.
> [~jamestaylor]

This message was sent by Atlassian JIRA

View raw message