phoenix-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ethan Wang (JIRA)" <j...@apache.org>
Subject [jira] [Comment Edited] (PHOENIX-4150) Adding a policy filter to whitelist the properties that allow to be passed to Phoenix
Date Thu, 07 Sep 2017 06:31:00 GMT

    [ https://issues.apache.org/jira/browse/PHOENIX-4150?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16156551#comment-16156551
] 

Ethan Wang edited comment on PHOENIX-4150 at 9/7/17 6:30 AM:
-------------------------------------------------------------

Special note: No test for this PolicyProvider. 
PolicyProvider is following three other hbase factory providers (hconnection, htable and hconfig),
which leverage service loader to auto wire the interfaces. So far no test on these providers
on Phoenix side. The user customized impl will be tested on the user's code base.

Please advice/proceed on this.
[~jamestaylor] (+[~lhofhansl])


was (Author: aertoria):
Special note: No test for this PolicyProvider. (+[~lhofhansl])
PolicyProvider is following three other hbase factory providers (hconnection, htable and hconfig),
which leverage service loader to auto wire the interfaces. So far no test on these providers
on Phoenix side. The user customized impl will be tested on the user's code base.
[~jamestaylor] 

> Adding a policy filter to whitelist the properties that allow to be passed to Phoenix
> -------------------------------------------------------------------------------------
>
>                 Key: PHOENIX-4150
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-4150
>             Project: Phoenix
>          Issue Type: Bug
>            Reporter: Ethan Wang
>            Assignee: Ethan Wang
>         Attachments: PHOENIX-4150-v1.patch, PHOENIX-4150-v2.patch
>
>
> Adding a policy filter to whitelist the properties that allow to be passed to Phoenix.
> Feature proposal:
> When user getting phoenix connection via
> Connection conn = DriverManager.getConnection(connectionString, properties);
> A properties whitelist policy will essentially check each properties that passed in (likely
happen at PhoenixDriver.java), so that the un-allowed property will result in an exception
been thrown.
> Similar to HBaseFactoryProvider, proposing have a interface for whitelist policy and
a default impl that will by default allow all properties. User can override the impl for this
interface to start using whitelist feature
> [~jamestaylor]   [~alexaraujo]



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message