phoenix-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hadoop QA (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (PHOENIX-4138) Create a hard limit on number of indexes per table
Date Fri, 08 Sep 2017 20:43:00 GMT

    [ https://issues.apache.org/jira/browse/PHOENIX-4138?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16159300#comment-16159300
] 

Hadoop QA commented on PHOENIX-4138:
------------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12886128/PHOENIX-4138.patch
  against master branch at commit 6775dc5c489bd002186e8b5375dd89b666836067.
  ATTACHMENT ID: 12886128

    {color:green}+1 @author{color}.  The patch does not contain any @author tags.

    {color:red}-1 tests included{color}.  The patch doesn't appear to include any new or modified
tests.
                        Please justify why no new tests are needed for this patch.
                        Also please list what manual steps were performed to verify this patch.

    {color:green}+1 javac{color}.  The applied patch does not increase the total number of
javac compiler warnings.

    {color:green}+1 release audit{color}.  The applied patch does not increase the total number
of release audit warnings.

    {color:green}+1 lineLengths{color}.  The patch does not introduce lines longer than 100

    {color:green}+1 core tests{color}.  The patch passed unit tests in .

Test results: https://builds.apache.org/job/PreCommit-PHOENIX-Build/1409//testReport/
Console output: https://builds.apache.org/job/PreCommit-PHOENIX-Build/1409//console

This message is automatically generated.

> Create a hard limit on number of indexes per table
> --------------------------------------------------
>
>                 Key: PHOENIX-4138
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-4138
>             Project: Phoenix
>          Issue Type: Bug
>            Reporter: Rahul Shrivastava
>            Assignee: churro morales
>         Attachments: PHOENIX-4138.patch
>
>   Original Estimate: 48h
>  Remaining Estimate: 48h
>
> There should be a config parameter to impose a hard limit on number of indexes per table.
There is a SQL Exception https://github.com/apache/phoenix/blob/master/phoenix-core/src/main/java/org/apache/phoenix/exception/SQLExceptionCode.java#L260
, but it gets triggered on the server side  (https://github.com/apache/phoenix/blob/master/phoenix-core/src/main/java/org/apache/phoenix/coprocessor/MetaDataEndpointImpl.java#L1589)
. 
> We need a client side limit that can be configured via Phoenix config parameter. Something
like if user create more than lets say 30 indexes per table, it would not allow more index
creation for the that specific table. 



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message