phoenix-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "James Taylor (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (PHOENIX-4110) ParallelRunListener should monitor number of tables and not number of tests
Date Fri, 01 Sep 2017 19:37:00 GMT

    [ https://issues.apache.org/jira/browse/PHOENIX-4110?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16151058#comment-16151058
] 

James Taylor commented on PHOENIX-4110:
---------------------------------------

Congrats on the clean test run! Hopefully it's repeatable. I'm curious if the test execution
time would drop dramatically if we kill the mini cluster and exit the JVM. We'd need to only
do this in an AfterClass method, though, and we'd need to limit number of tables created in
a single test suite.

Maybe we can do a run where we synchronously shut down the mini cluster and keep track of
the cumulative time. That way we'll know the upper bound of the potential time savings.

> ParallelRunListener should monitor number of tables and not number of tests
> ---------------------------------------------------------------------------
>
>                 Key: PHOENIX-4110
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-4110
>             Project: Phoenix
>          Issue Type: Bug
>            Reporter: Samarth Jain
>            Assignee: Samarth Jain
>         Attachments: PHOENIX-4110.patch, PHOENIX-4110_v10.patch, PHOENIX-4110_V2_4.x-HBase-0.98.patch,
PHOENIX-4110_v3_4.x-HBase-0.98.patch, PHOENIX-4110_v3.patch, PHOENIX-4110_v4.patch, PHOENIX-4110_v5.patch,
PHOENIX-4110_v6.patch, PHOENIX-4110_v7.patch, PHOENIX-4110_v8.patch, PHOENIX-4110_v9.patch
>
>
> ParallelRunListener today monitors the number of tests that have been run to determine
when mini cluster should be shut down. This helps prevent our test JVM forks running in OOM.
A better heuristic would be to instead check the number of tables that were created by tests.
This way when a particular test class has created lots of tables, we can shut down the mini
cluster sooner.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message