phoenix-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hadoop QA (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (PHOENIX-4007) Surface time at which byte/row estimate information was computed in explain plan output
Date Fri, 15 Sep 2017 08:12:00 GMT

    [ https://issues.apache.org/jira/browse/PHOENIX-4007?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16167508#comment-16167508
] 

Hadoop QA commented on PHOENIX-4007:
------------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12887264/PHOENIX-4007_v4.patch
  against master branch at commit 052490e09f2271eaa84dc9ab123a62a87123a498.
  ATTACHMENT ID: 12887264

    {color:green}+1 @author{color}.  The patch does not contain any @author tags.

    {color:green}+1 tests included{color}.  The patch appears to include 9 new or modified
tests.

    {color:green}+1 javac{color}.  The applied patch does not increase the total number of
javac compiler warnings.

    {color:green}+1 release audit{color}.  The applied patch does not increase the total number
of release audit warnings.

    {color:red}-1 lineLengths{color}.  The patch introduces the following lines longer than
100:
    +                    + " (k INTEGER PRIMARY KEY, c1.a bigint, c2.b bigint) GUIDE_POSTS_WIDTH="
+ guidePostWidth);
+                || (lhsPlan.getEstimatedRowsToScan() == null || rhsPlan.getEstimatedRowsToScan()
== null)
+                || (lhsPlan.getEstimateInfoTimestamp() == null || rhsPlan.getEstimateInfoTimestamp()
== null)) {
+                            minGuidePostTimestamp = Math.min(minGuidePostTimestamp, gps.getGuidePostTimestamps()[guideIndex]);
+                    cells.add(KeyValueUtil.newKeyValue(row, EXPLAIN_PLAN_FAMILY, EXPLAIN_PLAN_ESTIMATE_INFO_TS,
+                if (gps.getSecond().addGuidePostOnCollection(row, byteCount, gps.getSecond().getRowCount()))
{
+    public static byte[] getAdjustedKey(byte[] key, byte[] tableNameBytes, ImmutableBytesWritable
cf, boolean nextKey) {
+                    // Use the timestamp of the cell as the time at which guidepost was created/updated
+                    guidePostsInfoBuilder.trackGuidePost(new ImmutableBytesWritable(newGPStartKey),
byteCount, rowCount, guidePostUpdateTime);
+        return current == null ? GuidePostsInfo.NO_GUIDEPOST : guidePostsInfoBuilder.isEmpty()
? GuidePostsInfo.EMPTY_GUIDEPOST : guidePostsInfoBuilder.build();

     {color:red}-1 core tests{color}.  The patch failed these unit tests:
     ./phoenix-pherf/target/failsafe-reports/TEST-org.apache.phoenix.pherf.PherfMainIT

Test results: https://builds.apache.org/job/PreCommit-PHOENIX-Build/1447//testReport/
Console output: https://builds.apache.org/job/PreCommit-PHOENIX-Build/1447//console

This message is automatically generated.

> Surface time at which byte/row estimate information was computed in explain plan output
> ---------------------------------------------------------------------------------------
>
>                 Key: PHOENIX-4007
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-4007
>             Project: Phoenix
>          Issue Type: Bug
>            Reporter: Samarth Jain
>            Assignee: Samarth Jain
>         Attachments: PHOENIX-4007_v1.patch, PHOENIX-4007_v2.patch, PHOENIX-4007_v3.patch,
PHOENIX-4007_v4.patch
>
>
> As part of PHOENIX-3822, we surfaced byte and row estimates for queries in explain plan.
Since we collect this information through stats collection, it would also be helpful to surface
when this information was last updated to reflect its freshness. We already store last_stats_update_time
in SYSTEM.STATS. So the task would be essentially surfacing last_stats_update_time as another
column in the explain plan result set.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message